Repository navigation
[eMudhra 53119][Node] Add Node 22.23.4 to CI matrix - #2790
Open
davidmreed wants to merge 1 commit into
Open
davidmreed wants to merge 1 commit into
davidmreed wants to merge 1 commit into
Conversation
Adds an exact 22.23.4 row (the Node 22 release with the eMudhra distrust in its bundled roots) next to the existing 20.x/22.x/24.x/26.x rows on ubuntu and windows. No rows removed; package engines unchanged. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
.github/workflows/ci-build.yml: adds"22.23.4"to thenode-versionmatrix, next to the existing20.x,22.x,24.xand26.xrows. It runs on bothubuntu-latestandwindows-latestand with bothundici@^7andundici@^8. 22.23.4 is the Node 22 release that ships the eMudhra distrust in its bundled root store.excludeentry (20.x+undici@^8) is unchanged and still applies only to 20.x.LATEST_SUPPORTED_NODEstays24.x, so the new row runsnpm test, not coverage or docs.enginesinpackages/*/package.jsonare not changed.Where it ships
enginesfields are consumer ranges (e.g.packages/web-api/package.json:24>= 20,packages/rtm-api/package.json:25>=18). Node uses its own bundled roots, so the fix for consumers is the Node runtime they run. This PR adds CI coverage on a fixed Node 22 release.20.xrow (ci-build.yml:22) is kept. Node 20 is EOL and will never get a release with the fix. Whether to raise the supported floor and drop 20.x is a maintainer decision and is outside this PR.release.yml:30,105(node-version: 24) and the22.x/24.x/26.xrows.Not covered by this PR
engines. Maintainer decision.Verification
action_required. The results below are from local runs.In
node:22.23.4(Linux), I ran the same steps as the matrix job for each undici variant:npm ci,npm install undici@^N --workspace=packages/socket-mode --no-save,npm run build,npm run lint,npm test.undici@^7: build, lint and test all exit 0.undici@^8: build, lint and test all exit 0.🤖 Generated with Claude Code
Part of the eMudhra 53119 CA-distrust remediation (CVE-2026-111943).