Skip to content

[eMudhra 53119][Node] Add Node 22.23.4 to CI matrix - #2790

Open
davidmreed wants to merge 1 commit into
slackapi:mainfrom
davidmreed:emudhra-53119/node
Open

davidmreed wants to merge 1 commit into
slackapi:mainfrom
davidmreed:emudhra-53119/node

Conversation

@davidmreed

@davidmreed davidmreed commented Oct 22, 2026 •

Copy link
Copy Markdown

What changes

  • .github/workflows/ci-build.yml: adds "22.23.4" to the node-version matrix, next to the existing 20.x, 22.x, 24.x and 26.x rows. It runs on both ubuntu-latest and windows-latest and with both undici@^7 and undici@^8. 22.23.4 is the Node 22 release that ships the eMudhra distrust in its bundled root store.
  • The exclude entry (20.x + undici@^8) is unchanged and still applies only to 20.x. LATEST_SUPPORTED_NODE stays 24.x, so the new row runs npm test, not coverage or docs.
  • No rows are removed. engines in packages/*/package.json are not changed.

Where it ships

  • These are npm packages, and their engines fields are consumer ranges (e.g. packages/web-api/package.json:24 >= 20, packages/rtm-api/package.json:25 >=18). Node uses its own bundled roots, so the fix for consumers is the Node runtime they run. This PR adds CI coverage on a fixed Node 22 release.
  • The 20.x row (ci-build.yml:22) is kept. Node 20 is EOL and will never get a release with the fix. Whether to raise the supported floor and drop 20.x is a maintainer decision and is outside this PR.
  • Already covered without changes: release.yml:30,105 (node-version: 24) and the 22.x/24.x/26.x rows.

Not covered by this PR

  • Dropping Node 20 or raising package engines. Maintainer decision.

Verification

  • CI: awaiting maintainer approval. This is a fork PR, and its workflow runs show action_required. The results below are from local runs.
    In node:22.23.4 (Linux), I ran the same steps as the matrix job for each undici variant: npm ci, npm install undici@^N --workspace=packages/socket-mode --no-save, npm run build, npm run lint, npm test.
  • undici@^7: build, lint and test all exit 0.
  • undici@^8: build, lint and test all exit 0.
  • The Windows rows were not run locally. They run in CI on this PR once a maintainer approves the workflow runs.

🤖 Generated with Claude Code
Part of the eMudhra 53119 CA-distrust remediation (CVE-2026-111943).

Adds an exact 22.23.4 row (the Node 22 release with the eMudhra
distrust in its bundled roots) next to the existing 20.x/22.x/24.x/26.x
rows on ubuntu and windows. No rows removed; package engines unchanged.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@davidmreed
davidmreed requested a review from a team as a code owner October 22, 2026 17:26
@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7a00759

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant