Skip to content

fix(gitlab-mark-viewed): support the rapid diffs viewer #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solcik merged 1 commit into from
Nov 4, 2026
Merged

fix(gitlab-mark-viewed): support the rapid diffs viewer #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions gitlab-mark-viewed.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// ==UserScript==
// @name GitLab — mark file as Viewed with "v"
// @namespace https://github.com/solcik/userscripts
// @version 0.5.1
// @description In a GitLab merge request diff, press "v" to toggle the focused file's "Viewed" checkbox, advancing to the next file — pinned under the sticky header — only when marking one viewed.
// @version 0.5.2
// @description In a GitLab merge request diff, press "v" (GitLab toggles the focused file's "Viewed" checkbox) and advance to the next file — pinned under the sticky header — only when marking one viewed.
// @author David Solc
// @match https://gitlab.com/*/-/merge_requests/*
// @match https://git.vs-point.cz/*/-/merge_requests/*
Expand All @@ -21,8 +21,8 @@
(function () {
'use strict';

const FILE = '.diff-file.file-holder';
const REVIEW_CHECKBOX = "[data-testid='fileReviewCheckbox']";
const FILE = 'diff-file, .diff-file.file-holder';
const REVIEW_CHECKBOX = "[data-testid='fileReviewCheckbox'], input[data-viewed-checkbox]";
const NEXT_FILE_KEY = 'j';
const EDGE = 4;
const SETTLE_MS = 400;
Expand Down Expand Up @@ -108,22 +108,22 @@
})();
}

// GitLab now binds "v" ("Viewed by me") itself. Clicking the checkbox here
// too would toggle it twice, so let GitLab toggle and only watch the result.
Mousetrap.bind('v', function () {
const file = focusedFile();
const checkbox = file && file.querySelector(REVIEW_CHECKBOX);
if (!checkbox) return;

// Un-reviewing expands the file again, which is the whole point of pressing
// "v" on an already-viewed file — stay put so it can actually be read.
const marking = !checkbox.checked;

checkbox.click();
if (!marking) return;

const was = checkbox.checked;
const key = fileKey(file);
requestAnimationFrame(function () {

setTimeout(function () {
// Un-reviewing expands the file again, which is the whole point of
// pressing "v" on an already-viewed file — stay put so it can be read.
if (was || !checkbox.checked) return;
goToNextFile();
pinNextFile(key);
});
}, 50);
});
})();
Loading