Skip to content

fix(gitlab-mark-viewed): advance after marking rapid diffs viewed - #8

Merged
davidsolc-ai merged 1 commit into
mainfrom
gitlab-viewed-next
Nov 5, 2026
Merged

davidsolc-ai merged 1 commit into
mainfrom
gitlab-viewed-next

Conversation

@davidsolc-ai

Copy link
Copy Markdown
Collaborator

Pressing v on a single-commit rapid diff marks the file viewed but leaves the same file selected.

The script now captures v before GitLab handles it. It toggles the checkbox once and advances through the single-file viewer's Next button. Multi-file rapid diffs select the next diff directly. The legacy viewer retains its j shortcut.

Version 0.5.3 removes the Mousetrap dependency. Unmarking a file keeps it selected. The handler ignores text input, modifiers, composition, and repeated key events.

Validation:

  • Tested MR 509 on git.vs-point.cz with commit ad36a8f04801bb0531288012484de1edefec0f52 in Chrome.
  • Verified that marking file 1 advances to file 2 of 25.
  • Verified that unmarking a file keeps it selected.
  • Passed six browser fixture checks for navigation, input guards, and the final-file boundary.
  • Passed repository lint and format checks.

@davidsolc-ai
davidsolc-ai merged commit 146080e into main Nov 5, 2026
2 checks passed
@davidsolc-ai
davidsolc-ai deleted the gitlab-viewed-next branch November 5, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant