Skip to content

Show and revoke app logins, protect API token creation - #1387

Draft
korridor wants to merge 4 commits into
mainfrom
feature/app-sessions-and-api-token-security
Draft

korridor wants to merge 4 commits into
mainfrom
feature/app-sessions-and-api-token-security

Conversation

@korridor

@korridor korridor commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@korridor
korridor requested a review from Onatcer November 9, 2026 11:46
@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.21053% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.76%. Comparing base (369b012) to head (9d73991).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/Models/Passport/Token.php 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1387      +/-   ##
============================================
- Coverage     93.81%   93.76%   -0.06%     
- Complexity     2419     2425       +6     
============================================
  Files           323      325       +2     
  Lines         11152    11206      +54     
============================================
+ Hits          10462    10507      +45     
- Misses          690      699       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Onatcer

Onatcer commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

can we not do a bunch of auth changes while the SSO branch is unmerged? or at least do them in the SSO PR? SSO users are not required to have passwords so password confirmation does not work there. Some features are therefore disabled (PW change, 2FA), some don't require the password confirmation (log out from all browsers).

@Onatcer

Onatcer commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Blocked by #1131

@Onatcer

Onatcer commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

if we protect API token creation this way we would also have to do it for OAuth imo because otherwise you can just issue a token via the OAuth flow without a password confirmation, so it does not actually do anything from a secruity hardening perspective.

@korridor
korridor marked this pull request as draft November 16, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants