Skip to content

skill: Cut legacy docs branches at the release publish time, not the main tip - #2093

Merged
marcleblanc2 merged 4 commits into
mainfrom
aditi/skill-docs-version-cutoff
Oct 26, 2026
Merged

marcleblanc2 merged 4 commits into
mainfrom
aditi/skill-docs-version-cutoff

Conversation

@aditiabhang

@aditiabhang aditiabhang commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

When 8.1 was released, v8_0 was cut from the origin/main tip fb50b82b (#2090, "Merge after 8.1 releases", merged six minutes after 8.1.0 was published). 8.1 content landed in the 8.0 archive; it was re-cut from ddfe8c2. The skill told the agent to use the last commit on the release date or the tip, and never checked the release time. 7.7 had the same bug: v7_6 includes #1843, merged 22 hours after 7.7.0 was published.

Changes

  • The X.Y.0 publish time (GitHub release published_at, changelog API as fallback) is a hard ceiling. Tag time is not used: it predates the public release by up to a day.
  • List docs PRs merged at or after it and check none is an ancestor of the cut.
  • Flag, for a human decision, PRs between the X.Y.x branch cut and the ceiling: "merge after" notes, generated-docs syncs after the branch cut, and docs PRs whose linked sourcegraph PR is on X.Y.x.
  • The agent proposes the cut with evidence and waits for confirmation before pushing the legacy branch.

Checked against history

Test plan

  • cspell on the file: 0 issues.
  • All commands run against 8.1.0, 8.0.0, 7.7.0.

Follow-ups

  • DNS PR, Vercel domain mapping and verify steps.
  • docs/legacy.mdx entries for new majors.
  • robots.txt worker: hostname.split(".")[0] gives 8, not 8.0.

…main tip

During the 8.1 cutover, v8_0 was cut from the origin/main tip (fb50b82, #2090), which was merged six minutes after 8.1.0 was published and was marked "Merge after 8.1 releases". The skill told the agent to prefer the last commit on the release date or the tip, and never checked the actual release time.

The cut-point section now uses the X.Y.0 publish time as a hard ceiling, lists docs PRs merged at or after it, flags PRs that may carry X.Y content (merge-after notes, post-branch-cut generated syncs, linked sourcegraph PRs on the X.Y.x branch), and requires the agent to propose the cut with evidence and wait for confirmation before creating or pushing the legacy branch.

Amp-Thread-ID: https://ampcode.com/threads/T-01a140f9-34fa-726b-90c5-1608b2a7cc81
@aditiabhang
aditiabhang requested a review from enriquegh October 15, 2026 19:29
@vercel

vercel Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sourcegraph-docs Ready Ready Preview Oct 26, 2026 6:52pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

@github-actions

This comment has been minimized.

@aditiabhang
aditiabhang marked this pull request as ready for review October 16, 2026 19:22
@marcleblanc2
marcleblanc2 enabled auto-merge (squash) October 26, 2026 18:50
@marcleblanc2
marcleblanc2 merged commit 5ca7c83 into main Oct 26, 2026
7 checks passed
@marcleblanc2
marcleblanc2 deleted the aditi/skill-docs-version-cutoff branch October 26, 2026 18:53

This branch was successfully deployed

1 active deployment
Preview — 98fec84a Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants