Repository navigation
Conversation
Fixes spring-cloudgh-2148 Signed-off-by: anqorithm <61029571+anqorithm@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2148
The docs say a
DiscoveryClientimplementation is enough, butGatewayDiscoveryClientAutoConfigurationonly builds the locator from aReactiveDiscoveryClient. A blocking client on its own never gets called, as the issue shows.This changes the wording on that page and notes that the locator isn't created when
spring.cloud.discovery.reactive.enabledisfalse.I left the property prefixes alone because #4090 already updates them. Both PRs touch the "To enable this" line, so whichever merges second will need a small rebase.
Docs only. I checked the wording against the auto-configuration, but I didn't build the docs site.