Repository navigation
Modernize exception assertions in BaseTaskExecutionDaoTestCases - #1041
Open
siddiqueirshad wants to merge 1 commit into
Open
siddiqueirshad wants to merge 1 commit into
siddiqueirshad wants to merge 1 commit into
Conversation
siddiqueirshad
force-pushed
the
modernize-dao-exception-tests
branch
from
November 2, 2026 15:27
52bc9e8 to
cbf779b
Compare
cppwfs
requested changes
Nov 4, 2026
| return; | ||
| } | ||
| fail("Expected an IllegalArgumentException to be thrown."); | ||
| assertThatThrownBy(() -> this.dao.getLatestTaskExecutionsByTaskNames(null)) |
Collaborator
There was a problem hiding this comment.
Update the tests to use assertThatIllegalArgumentException to be a little more concise.
Collaborator
|
Thank you for your contribution! |
Author
|
Hi @cppwfs, thank you for the review! I have updated all five tests to use �ssertThatIllegalArgumentException().isThrownBy(...).withMessage(...) to make them more concise as requested. |
Collaborator
|
Thank you for your contribution. Can you please follow sign your commit according to our DCO policy found here: https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring Thanks! |
Signed-off-by: siddiqui irshad <mohdirshad1306@gmail.com>
siddiqueirshad
force-pushed
the
modernize-dao-exception-tests
branch
from
November 4, 2026 18:35
f40896b to
34dfb71
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Summary
This pull request modernizes exception assertions in
BaseTaskExecutionDaoTestCasesby transitioning legacytry / catch / failboilerplate to standard AssertJ fluent assertions usingassertThatThrownBy(...).Changes Made
BaseTaskExecutionDaoTestCases:getLatestTaskExecutionsByTaskNamesWithNullParameter: modernized withassertThatThrownBy.getLatestTaskExecutionsByTaskNamesWithEmptyArrayParameter: modernized withassertThatThrownBy.getLatestTaskExecutionsByTaskNamesWithArrayParametersContainingNullAndEmptyValues: modernized withassertThatThrownBy.getLatestTaskExecutionForTaskNameWithNullParameter: modernized withassertThatThrownBy.getLatestTaskExecutionForTaskNameWithEmptyStringParameter: modernized withassertThatThrownBy.failstatic import withassertThatThrownBy.