Repository navigation
fix: do not merge type annotations that are also parameter annotations - #3394
Open
jochenberger wants to merge 1 commit into
Open
jochenberger wants to merge 1 commit into
jochenberger wants to merge 1 commit into
Conversation
Since springdoc#3377, an annotation applicable to both declarations and types, such as @Valid or @NotNull, is forwarded twice to swagger-core. The duplicate changes the cache key of the resolved schema, so a subtype of a polymorphic parent can be resolved again after its parent and lose its allOf reference. Fixes springdoc#3393
| * A subtype loses its allOf reference to the polymorphic parent when a controller method | ||
| * repeats the @Valid of the interface method it implements. | ||
| */ | ||
| public class SpringDocApp283Test extends AbstractCommonTest { |
Contributor
There was a problem hiding this comment.
The api tests are mainly designed as blackbox tests that verify that the produced specification aligns with the expected one (name derived from test name).
Could we also consider adding a test to v30 so that we ensure that the test numbers align between the two?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #3377, an annotation applicable to both declarations and types, such as @Valid or @NotNull, is forwarded twice to swagger-core. The duplicate changes the cache key of the resolved schema, so a subtype of a polymorphic parent can be resolved again after its parent and lose its allOf reference.
Fixes #3393