Skip to content

docs(debug-journal): fold the 2026-10-30..31 queue slice (14 of 15 candidates); correct entries fixed by #5921/#5909/#5984/#5998/#6021 - #6043

Merged
springfall2008 merged 1 commit into
mainfrom
bot/debug-journal-2026-11-08
Nov 8, 2026
Merged

springfall2008 merged 1 commit into
mainfrom
bot/debug-journal-2026-11-08

Conversation

@springfall2008

Copy link
Copy Markdown
Owner

Automated fold of the journal queue slice for 2026-11-08 (branch bot/debug-journal-2026-11-08, one commit, docs-only: tools/debug-journal.md). Every candidate was re-verified against current main (3c647e9) before folding; file is now 154.9KB (was 146.7KB — the ~150KB guidance is now slightly exceeded even after consolidation, see below).

Candidates (15 offered, 14 folded, 1 dropped)

  • 5869 (add-on packaging/runtime layout) — folded as two bullets under Versions, logs and attachments: /config/*.py tracebacks = flattened release layout with release-tag line numbers (download gated on /config/apps.yaml, so reinstall doesn't refresh); bad marshal data from _compile_bytecode = corrupt bytecode in the locally built add-on container (no prebuilt image), classify configuration. Re-verified the add-on repo facts today by fetching startup.py, Dockerfile and config.yaml from springfall2008/predbat_addon main. The candidate's permission-quirk notes (curl-over-gh) were dropped as session-specific tooling, and the reinstall-failure cause is kept marked suspected.
  • 5872 (stored-energy term map) — folded as one bullet under Check configuration before code: the four battery_value_rate() inputs' build stages, rate_scan() no longer building rate_min_forward, and the two replay traps (stale rate_min_forward in non-fetch rate-table installs; old dumps restore session-inclusive values, use --redo). Verified against the merged PR fix(plan): value stored energy at the tariff's own rates, not saving/free sessions #5872 code (docstring + fetch.py build sites + plan.py:2618 fallback).
  • 5873 + 5883 (apps.yaml energy totals ignored under _automatic) — folded together as one Symptom → first place to look bullet with the per-component adoption map (GivTCP four keys, Sigenergy two, Hanchu four since fix(hanchu): let an apps.yaml entry win for the four daily energy totals #5883, GE Cloud plain set_arg, Solis still overwriting import_today/export_today unconditionally) — verified on main today (solis.py reads past the solis_cloud_pv_load_ignore gate for import/export).
  • 5874 (export threshold per 5 minutes) — dropped: its durable residue (per-5-minute charging, merged PR fix(plan): charge metric_min_improvement_export per 5 minutes of export #5874) was already in the journal; the stale-docstring trap it flagged was fixed the same week (89e2589 — plan.py:4166 now says "monotonic in that score rather than in the raw metric"); the metric_min_improvement_export can't remove a forced export seeded by the levels pass #5633 mechanism was fully fixed by fix(plan): an export must earn its keep on the nominal metric, and passes let go of one that doesn't #5977. Its one surviving correction (see below) was applied anyway.
  • 5876 + 5882 (module-global dropdown options) — folded together as a Self-update bullet: both PRs verified merged; the fixed code assigns per-engine lists and tests pin the globals are never written.
  • 5877 (Storage.save() failure-by-False) — folded into the renamed Storage (storage.py) section. The PR's own live-instance finding was fixed before merge (save_execution_state() checks saved is False), so the entry keeps the general trap plus the still-live instance: save_plan() still ignores the bool (verified today, predbat.py:974-978).
  • 5878 (golden scope) — folded into Replays and debug dumps: goldens compare only the four window/limit arrays; plan_final.json is never diffed, so plan-JSON-only PRs need no golden regeneration; the candidate's claim about plan_final.json mirroring the live publish path verified at test_single_debug.py:317 (show_scenarios=True). The candidate's named test (test_hahistory_snapshot_then_delta) does not exist under that name and was left out.
  • 5879 (get_history db path ignores from_time) — folded into History fetch / memory: verified verbatim on main (early return before the from_time branch, get_history_db(sensor, now, days) payload) plus the days=1, from_time=<epoch> delta caller; the candidate's test name was dropped.
  • 5881 (Solis reserve arg display-only for has_reserve_soc: false) — folded into the Solis section, noting Add Solis local inverter definition #5881 merged (2026-11-07) and that the shipped template is templates/solis_local.yaml (solis_rc); verified the reserve read-back/dummy-replacement and the fleet-wide reserve-disable block on main.
  • 5884 (IOG charging-unlisted boundary tail) — folded into the Octopus dispatches area: symptom, the growing-amount tell, the boundary-cycle mechanism, and open PR fix(iog): don't take a dispatch's charging tail for an unlisted smart charge (#5884) #5907 (octopus_dispatch_tail verified absent from main); the unresolved billed-at-discount question stays marked waiting-for-reporter.
  • 5885 (cannot-be-modified allowlist drift) — folded into Startup, config and apps.yaml: allowlist verified unchanged on main (input_number still duplicated, input_select missing) — nothing fixed yet, red/green recipe included.
  • 5886 (HA-restart family refinements) — folded as sharpening of the existing startup row: the 0/120/360 s retry schedule (ComponentBase.start() doubles after the attempt), the wrapper's own Shutdown, sleeping 20 seconds before restarting line, and the community-added-fixed-labels caution (fix(ha): ride out a Home Assistant restart instead of stopping after 10 errors #5449/Fix #5134: don't wait out wait_api_started() for a component whose dependency never constructed #5323 still open — fix(ha): ride out a Home Assistant restart instead of stopping after 10 errors #5449 verified NOT on main today).
  • 5888 (SK accepted-but-never-landed service dedup) — folded as a sharpening of the Inverter control and writes service-calls bullet (rejected vs accepted-but-died halves; repeat:/always: discriminator); the dedup-recording shape verified on main.

Existing entries corrected (merges since the last fold)

Consolidation

File passed ~150KB, so in the same PR: the owner-gate GitHub-merge-box entry was cut to its fixed mechanism (its story landed 2026-11-06, fix = commit-status change), and two stale fixed rows were deleted (GE Cloud PR #5218 label crash, >6 weeks old; Solis "discharge capped at the charge limit" fixed #5308, >6 weeks old). File is 154.9KB — a fuller consolidation pass is probably its own PR.

Left queued: 102 candidates.

…ndidates); correct entries fixed by #5921/#5909/#5984/#5998/#6021

Co-Authored-By: Claude Code <noreply@anthropic.com>
@springfall2008
springfall2008 marked this pull request as ready for review November 8, 2026 09:32
@springfall2008
springfall2008 enabled auto-merge (squash) November 8, 2026 09:32
@github-actions github-actions Bot added the BOT_REVIEW Trigger an autotriage label Nov 8, 2026
@springfall2008
springfall2008 merged commit 758956b into main Nov 8, 2026
7 checks passed
@springfall2008
springfall2008 deleted the bot/debug-journal-2026-11-08 branch November 8, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BOT_REVIEW Trigger an autotriage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant