Skip to content

docs(debug-journal): note that a list passes validate_config's scalar string check - #6256

Draft
springfall2008 wants to merge 2 commits into
mainfrom
bot/debug-journal-2026-11-18
Draft

springfall2008 wants to merge 2 commits into
mainfrom
bot/debug-journal-2026-11-18

Conversation

@springfall2008

Copy link
Copy Markdown
Owner

Automated: written by the triage bot's /journal-update flow, not by a person. Please do not merge without reading it — the whole point of this file is that later runs trust it.

Folds the first 15 candidates of the queue (plain filename sort), leaving 110 still queued for later slices. Every candidate was re-checked against main at f2e544f1 before folding: each claim was confirmed by reading the named symbol on the current tree, and anything that had since been fixed was rewritten or dropped rather than copied in.

Note for the reviewer: yesterday's fold (bot/debug-journal-2026-11-17, b24f9c1) is not on main yet, so this branch is cut from the same 226,590-byte file and the two will conflict in the regions both touch. Merging either first is fine; the other needs its hunks re-applied.

Folded

  • 6089 codespaces toolchain → Tests and the C++ kernel, "Tests that fail only in one dev container". Kept because it cost a real investigation and recurs for anyone on an old container: asyncio.wait_for leaves a wrapper task pending before Python 3.12 (four sigenergy cancellation tests), and jq 1.6 rejects a $label variable so all 14 owner-gate tests fail. Added that main's devcontainer now pins 3.12 + jq 1.7.1 (PR fix #6089 codespaces environment issues #6090, merged as b131137).
  • 6093 HA recorder "(None) cannot be converted" → Sensors, history and load data. Confirmed publish_temperature_sensor() sets unit_of_measurement/device_class/state_class and returns without publishing at current_temp is None, so no current Predbat path produces the shape; kept the rule-out plus the "does it recur" discriminator.
  • 6098 get_arg() HA-config path → Check configuration before code, two new bullets under the get_arg() traps. Confirmed the order on main (get_ha_config() before self.args, resolve_arg() only on the args path) and the CONFIG_ITEMS default/value mutation. Dropped the candidate's own "unverified" paragraph about which items the args-seeded default shadows — it was explicitly flagged as not to be relied on.
  • 6102 plan-age gate quantised → Plan: charging and holding. Re-read the gate (strict >, RUN_EVERY 5, default calculate_plan_every 10) before folding.
  • 6103 / 6104 web login (four candidates) → one bullet in Web, MCP and Chat. PR feat(web): optional web_username/web_password login for settings pages #6104 merged (3c040e4) after those candidates were written, so the entry describes current behaviour rather than a draft: the prefix tuple, the fail-closed half-config case, the "adding a route does not add it to the gate" trap, and POST /api/login never having authenticated anything. Also folded the required_true registry-default fix into Component auto-config gate.
  • 6103 web UI unauthenticated — not folded as written, because PR feat(web): optional web_username/web_password login for settings pages #6104 fixed it. Its one still-true clause (/api/login is a reverse-proxy cookie helper, not auth) went into the new bullet.
  • 6104 validate_config warn-and-continue → Startup, config and apps.yaml, plus the list-passes-a-scalar-string fact as a schema-test tip.
  • 6104 web-auth prefix list → merged into the web-login bullet rather than given a second entry.
  • 6105 watch_list event refire → Startup, config and apps.yaml. Re-read trigger_watch_list() and watch_event(): no change test, plan_valid = False unconditional. Dropped the candidate's docs-mismatch clause — the octopus_saving_session example was removed by PR fix(templates): stop watching octopus_saving_session in watch_list #6107 and docs(anker): add Marketplace install steps and drop stale watch_list entries #6192.
  • 6107 grep -E '\s' on macOS → GitHub and tooling.
  • 6108 merged charge window across a rate rise → Plan: charging and holding. Re-read both functions on main: clip_charge_slots()'s clip-up branches and discard_unused_charge_slots()'s price check, which is skipped unless set_charge_low_power is on.
  • 6109 export-limit marshaller → folded as a sharpening of the existing "CI runs the quick suite in the pre-commit job" bullet (the job builds the kernel and sets PREDBAT_KERNEL_REQUIRED=1, so CI --quick does cover the kernel path). The rest of that candidate is PR-specific call-graph and fixture analysis, so it stays in PR perf(kernel): stop re-checking export limits on every marshal #6109.
  • 6110 between-cycles dispatch withdrawn → two bullets in Octopus: the withdrawn/short pair with its mechanism, and the separate trap that car charging in its dispatch, preferring battery charge ... prints with no charging evidence. Confirmed octopus_charging_unlisted() reads current_state off the slot entity.

Dropped

Existing entries corrected

Each was invalidated by a merge in the last two weeks:

Consolidation

  • Merged the separate "MagicMock bases wake up host hooks" and "Stub and constructor shapes" bullets into one test-double shapes bullet, keeping all three facts.
  • Retired the fix(octopus): model a vanishing IOG dispatch for octopus_intelligent_slot users #5304 IOG "battery flat inside an evening dispatch" story (fix 7 weeks old, nothing trips over it now) and kept the part still needed for reading dumps: even --redo replays reuse the dump's rate_import/io_adjusted.

The file went 226,590 → 234,793 bytes. I did not force it down to the 150KB guidance: these bullets are fact-dense and nearly all post-date the 5 Nov compaction, so hitting a byte target would have meant deleting verified findings. A dedicated compaction pass is still worth doing, with Octopus (11.1KB), Plan: charging and holding (7.9KB), Sigenergy (7.4KB), Inverter control and writes (7.1KB) and Tests and the C++ kernel (7.2KB) the biggest candidates.

Verification

  • git fetch origin main; all reads against f2e544f1.
  • python3 -m pre_commit run --files tools/debug-journal.md → trailing whitespace, end-of-file, markdownlint and cspell all pass. Note the ./run_pre_commit wrapper referenced by CLAUDE.md does not exist in this clone, so the hooks were run directly on the changed file; the quick suite is not run here, and CI's pre-commit job runs it anyway for a docs-only change.

🤖 Generated with Claude Code

CI and others added 2 commits November 18, 2026 00:07
…ct three entries fixed since

Fold 12 of the 15 queued candidates: the web Basic-auth gate (PR #6104, now merged), the plan-age gate and the merged charge window across a rate rise, watch_list event refires, the HA recorder (None)-unit warning, get_arg's HA-config path, validate_config's warn-and-continue, the withdrawn/short dispatch pair, macOS grep -E whitespace, the dev-container version traps, the web-server test teardown, and CI's kernel requirement.

Correct three entries overtaken by merges: PR #5766 is no longer an open fix PR, PR #5642 now logs an apps.yaml parse error to predbat.log, and PR #5651 fixed the per-inverter list warning for inverter_reserve_max.

Merge the MagicMock and stub-shape test-double traps, and retire the long-fixed #5304 IOG story keeping its replay caveat.

Co-Authored-By: Claude Code <noreply@anthropic.com>
… string check

A list given where the schema says string is checked item by item and passes, so a schema test's negative case must use a mapping. (PR #6104 review)

Co-Authored-By: Claude Code <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant