Repository navigation
docs(debug-journal): note that a list passes validate_config's scalar string check - #6256
Draft
springfall2008 wants to merge 2 commits into
Draft
springfall2008 wants to merge 2 commits into
springfall2008 wants to merge 2 commits into
Conversation
…ct three entries fixed since Fold 12 of the 15 queued candidates: the web Basic-auth gate (PR #6104, now merged), the plan-age gate and the merged charge window across a rate rise, watch_list event refires, the HA recorder (None)-unit warning, get_arg's HA-config path, validate_config's warn-and-continue, the withdrawn/short dispatch pair, macOS grep -E whitespace, the dev-container version traps, the web-server test teardown, and CI's kernel requirement. Correct three entries overtaken by merges: PR #5766 is no longer an open fix PR, PR #5642 now logs an apps.yaml parse error to predbat.log, and PR #5651 fixed the per-inverter list warning for inverter_reserve_max. Merge the MagicMock and stub-shape test-double traps, and retire the long-fixed #5304 IOG story keeping its replay caveat. Co-Authored-By: Claude Code <noreply@anthropic.com>
… string check A list given where the schema says string is checked item by item and passes, so a schema test's negative case must use a mapping. (PR #6104 review) Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated: written by the triage bot's
/journal-updateflow, not by a person. Please do not merge without reading it — the whole point of this file is that later runs trust it.Folds the first 15 candidates of the queue (plain filename sort), leaving 110 still queued for later slices. Every candidate was re-checked against
mainatf2e544f1before folding: each claim was confirmed by reading the named symbol on the current tree, and anything that had since been fixed was rewritten or dropped rather than copied in.Note for the reviewer: yesterday's fold (
bot/debug-journal-2026-11-17, b24f9c1) is not on main yet, so this branch is cut from the same 226,590-byte file and the two will conflict in the regions both touch. Merging either first is fine; the other needs its hunks re-applied.Folded
asyncio.wait_forleaves a wrapper task pending before Python 3.12 (four sigenergy cancellation tests), and jq 1.6 rejects a$labelvariable so all 14 owner-gate tests fail. Added that main's devcontainer now pins 3.12 + jq 1.7.1 (PR fix #6089 codespaces environment issues #6090, merged as b131137).publish_temperature_sensor()setsunit_of_measurement/device_class/state_classand returns without publishing atcurrent_temp is None, so no current Predbat path produces the shape; kept the rule-out plus the "does it recur" discriminator.get_arg()HA-config path → Check configuration before code, two new bullets under theget_arg()traps. Confirmed the order on main (get_ha_config()beforeself.args,resolve_arg()only on the args path) and theCONFIG_ITEMSdefault/valuemutation. Dropped the candidate's own "unverified" paragraph about which items the args-seeded default shadows — it was explicitly flagged as not to be relied on.>,RUN_EVERY5, defaultcalculate_plan_every10) before folding.POST /api/loginnever having authenticated anything. Also folded therequired_trueregistry-default fix into Component auto-config gate./api/loginis a reverse-proxy cookie helper, not auth) went into the new bullet.stringfact as a schema-test tip.trigger_watch_list()andwatch_event(): no change test,plan_valid = Falseunconditional. Dropped the candidate's docs-mismatch clause — theoctopus_saving_sessionexample was removed by PR fix(templates): stop watching octopus_saving_session in watch_list #6107 and docs(anker): add Marketplace install steps and drop stale watch_list entries #6192.grep -E '\s'on macOS → GitHub and tooling.clip_charge_slots()'s clip-up branches anddiscard_unused_charge_slots()'s price check, which is skipped unlessset_charge_low_poweris on.pre-commitjob" bullet (the job builds the kernel and setsPREDBAT_KERNEL_REQUIRED=1, so CI--quickdoes cover the kernel path). The rest of that candidate is PR-specific call-graph and fixture analysis, so it stays in PR perf(kernel): stop re-checking export limits on every marshal #6109.car charging in its dispatch, preferring battery charge ...prints with no charging evidence. Confirmedoctopus_charging_unlisted()readscurrent_stateoff the slot entity.Dropped
Existing entries corrected
Each was invalidated by a merge in the last two weeks:
fatal_errorlatch bullet — listed PR fix(ha): retry Home Assistant API during Predbat startup #5766 among "fix PRs open"; it merged on 2026-11-14. Now says so.!secrethint. Rewritten to distinguish before/after.inverter_reserve_maxonly; the check still runs for every other item (confirmed at the warn site on main).Consolidation
--redoreplays reuse the dump'srate_import/io_adjusted.The file went 226,590 → 234,793 bytes. I did not force it down to the 150KB guidance: these bullets are fact-dense and nearly all post-date the 5 Nov compaction, so hitting a byte target would have meant deleting verified findings. A dedicated compaction pass is still worth doing, with Octopus (11.1KB), Plan: charging and holding (7.9KB), Sigenergy (7.4KB), Inverter control and writes (7.1KB) and Tests and the C++ kernel (7.2KB) the biggest candidates.
Verification
git fetch origin main; all reads againstf2e544f1.python3 -m pre_commit run --files tools/debug-journal.md→ trailing whitespace, end-of-file, markdownlint and cspell all pass. Note the./run_pre_commitwrapper referenced by CLAUDE.md does not exist in this clone, so the hooks were run directly on the changed file; the quick suite is not run here, and CI'spre-commitjob runs it anyway for a docs-only change.🤖 Generated with Claude Code