Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/endtoend/testdata/duckdb_rowid/duckdb/exec.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"contexts": ["base"]
}
31 changes: 31 additions & 0 deletions internal/endtoend/testdata/duckdb_rowid/duckdb/go/db.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions internal/endtoend/testdata/duckdb_rowid/duckdb/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

169 changes: 169 additions & 0 deletions internal/endtoend/testdata/duckdb_rowid/duckdb/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions internal/endtoend/testdata/duckdb_rowid/duckdb/query.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
-- name: WithRowID :many
SELECT rowid, id FROM plan;

-- name: WithQualifiedRowID :many
SELECT p.rowid, p.id FROM plan p;

-- name: ByRowID :one
SELECT id FROM plan WHERE rowid = $1;

-- name: OrderByRowID :many
SELECT id FROM plan ORDER BY rowid;

-- name: StarSkipsRowID :many
SELECT * FROM plan;

-- name: DeclaredRowID :many
SELECT rowid, name FROM tag;
10 changes: 10 additions & 0 deletions internal/endtoend/testdata/duckdb_rowid/duckdb/schema.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
CREATE TABLE plan (
id UUID NOT NULL,
ship_size VARCHAR NOT NULL,
price DOUBLE
);

CREATE TABLE tag (
rowid VARCHAR NOT NULL,
name VARCHAR NOT NULL
);
10 changes: 10 additions & 0 deletions internal/endtoend/testdata/duckdb_rowid/duckdb/sqlc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
version: "2"
sql:
- engine: "duckdb"
schema: "schema.sql"
queries: "query.sql"
gen:
go:
package: "querytest"
out: "go"
sql_package: "database/sql"
19 changes: 19 additions & 0 deletions internal/engine/duckdb/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -1061,6 +1061,25 @@ func (c *cc) convertCreateTableInfo(info *dw.CreateTableInfo) ast.Node {
for i := range info.Columns {
stmt.Cols = append(stmt.Cols, c.convertColumnDef(&info.Columns[i], primaryKey))
}

// Every base table also has a rowid pseudo-column. It is a nullable
// BIGINT that queries can select, filter and sort on, but it is not part
// of the table's columns. A column the table declares as rowid takes
// precedence.
hasRowID := false
for _, col := range stmt.Cols {
if col.Colname == "rowid" {
hasRowID = true
break
}
}
if !hasRowID {
stmt.Cols = append(stmt.Cols, &ast.ColumnDef{
Colname: "rowid",
IsHidden: true,
TypeName: &ast.TypeName{Name: "bigint"},
})
}
return stmt
}

Expand Down
Loading