Repository navigation
Preserve time zone offsets in session values - #6170
Closed
bingdongni wants to merge 1 commit into
Closed
bingdongni wants to merge 1 commit into
bingdongni wants to merge 1 commit into
Conversation
Member
|
Thanks for finding this. Fixed in a smaller way (bf8b995): time zone aware values are now stored as their displayed text, so the deserializer doesn't need to grow (it's the hardened replacement for pickle, which I'd rather keep minimal). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A timezone-aware value returned by a database driver loses its offset when a session is reloaded. For example,
2024-01-02 03:04:00+05:30is resumed as2024-01-02 03:04:00.Store the observed UTC offset, DST offset, name and
foldwith datetime and time values. On reload the timezone is a fixed snapshot; its original transition rules are not reconstructed. Older session values remain readable, although offsets already omitted by older versions cannot be recovered.Tests:
test_replication. That module has six SQLite teardown errors on this platform, also reproduced on unmodified master.git diff --checkon the changed files.