Repository navigation
Preserve non-default ports in Host headers - #6171
Merged
stamparm merged 1 commit intoNov 3, 2026
Merged
Conversation
stamparm
added a commit
that referenced
this pull request
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getHostHeader strips both :80 and :443 regardless of the URL scheme. For example, http://example.com:443/ generates
Host: example.cominstead ofHost: example.com:443, which can route requests incorrectly on port-aware virtual hosts. HTTPS on port 80 has the same problem.Strip only the default port for the URL scheme, retaining non-default ports for hostnames and IPv6 addresses.
Tests:
test_replication. Its six SQLite teardown errors also reproduce on unmodified master.git diff --checkon the changed files.