Skip to content

chore: Dependency updates - #125

Merged
sbernauer merged 11 commits into
mainfrom
chore/upgrades-2026-11-17
Nov 18, 2026
Merged

sbernauer merged 11 commits into
mainfrom
chore/upgrades-2026-11-17

Conversation

@sbernauer

@sbernauer sbernauer commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Description

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

@sbernauer sbernauer self-assigned this Nov 17, 2026
@sbernauer
sbernauer requested a review from a team November 17, 2026 07:14
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Nov 17, 2026
NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 17, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there's no Cargo.nix

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 17, 2026
@sbernauer

Copy link
Copy Markdown
Member Author

I assume there's no Cargo.nix

It was actually very rarely used and thus gitignored. Added it now

Comment thread trino-lb-core/src/config.rs Resolved
@sbernauer

Copy link
Copy Markdown
Member Author

pre-commit complains about a missing newline in Cargo.nix, can be ignored

@NickLarsenNZ

Copy link
Copy Markdown
Member

pre-commit complains about a missing newline in Cargo.nix, can be ignored

We should add it to the exclusions (any generated file should be excluded from lints).

NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 17, 2026
@sbernauer

Copy link
Copy Markdown
Member Author

@NickLarsenNZ I removed the newline, as we also don't seem to have it for our operators

Comment thread Cargo.nix Resolved
NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 17, 2026
@sbernauer
sbernauer disabled auto-merge November 18, 2026 09:10
@sbernauer

Copy link
Copy Markdown
Member Author
--- PASS: kuttl (499.51s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_trino-lb-foo_bar_trino-483_persistence-postgres (257.31s)
        --- PASS: kuttl/harness/client-spooling_trino-lb-foo_bar_trino-483_client-spooling-retrieval-mode-COORDINATOR_PROXY (280.95s)
        --- PASS: kuttl/harness/smoke_trino-lb-foo_bar_trino-483_persistence-inMemory (78.89s)
        --- PASS: kuttl/harness/smoke_trino-lb-foo_bar_trino-483_persistence-redis (138.73s)
        --- PASS: kuttl/harness/client-spooling_trino-lb-foo_bar_trino-483_client-spooling-retrieval-mode-STORAGE (139.64s)
PASS

@sbernauer
sbernauer merged commit 53be3a3 into main Nov 18, 2026
8 checks passed
@sbernauer
sbernauer deleted the chore/upgrades-2026-11-17 branch November 18, 2026 09:11
@sbernauer sbernauer mentioned this pull request Nov 18, 2026
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering Nov 19, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants