Repository navigation
Use LOO CV with validated search in the vignettes and add alt text to the figures - #656
Merged
Merged
Conversation
…the Speed section
…act sizes and ratios
…est the latent reference model messages
…s_draws_matrix() too
… binomial examples, and decide the survival submodel sizes from the plots
…4 2.1-1 and the Laplace fitters
…ategorical families
aloctavodia
reviewed
Nov 18, 2026
aloctavodia
approved these changes
Nov 18, 2026
…ctions in the troubleshooting section
# Conflicts: # tests/testthat/test_extend_family.R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #526. Plus other updates.
Merge #655 first.
Vignettes
projpred.Rmd:cv_varsel()call with the defaults: LOO CV, validated search and forward search. The vignette no longer has the preliminary runs with L1 search and the K-fold CV withK = 2. The text on the results (ranking proportions, submodel size) follows the new output.y ~ ..?varseland?cv_varselpoint to this section.latent.Rmd:nloo = 10).cv_varsel(). The Poisson example compares the latent and the traditional projection with forward search.All 13 figures have alt text (
fig.alt). Each alt text names the plot type and the result that the vignette text reads from the figure. Five alt texts repeat submodel sizes from the vignette text; when these sizes change, update both places.Code
The latent-projection examples gave output that the vignette text had to explain. This PR changes that output:
NAdispersion.latent_ilinkmessage.as.matrix()andas_draws_matrix()of a latent projection have nosigmacolumn.New tests are in
test_extend_family.Randtest_latent.R.Checks
On Roihu (R 4.6.1),
projpred.Rmdrenders in 16 s andlatent.Rmdin 346 s. The full test suite withNOT_CRAN=truegives 0 failures and 0 errors, andR CMD checkgives 0 errors, 0 warnings and 0 notes.This PR was assisted by Claude.