Skip to content

feat(agent): add AgentSession.submit for host-agnostic input - #363

Merged
liuedcson merged 1 commit into
mainfrom
feat/agent-session-submit
Nov 19, 2026
Merged

liuedcson merged 1 commit into
mainfrom
feat/agent-session-submit

Conversation

@liuedcson

Copy link
Copy Markdown
Collaborator

背景

内核里"用户输入要先命令分发、再排队"这条语义只以 steer() 里一句 throw 的形式存在,于是每个宿主都得自己重新推导一遍,漏一个入口就出错:

  • 桌面端:回合进行中按 Cmd/Ctrl+Enter(session.steer())或回车(宿主自己的队列)发 /compact、/goal、插件命令,前者命中 Extension command "..." cannot be queued,后者把命令当普通消息排进队列;裸 /btw 也进了队列,回合结束才回 usage。
  • /clm 更糟:它由 _handleLiveContextCommand 在 prompt() 内部处理,不在扩展注册表里,所以 _throwIfExtensionCommand 拦不住 —— 排队后模型收到的是字面量 /clm status。
  • CLI 没出问题,但代价是三处各自特判(提交、compaction、队列 flush)加一份 isExtensionCommand 纯函数副本。

实现

1. 会话给出唯一入口与唯一判据(packages/coding-agent/src/core/agent-session.ts)

  • 新增 submit(text, { duringRun = "steer", ...rest }):内部委托给 prompt(),命令先分发、其余按 duringRun 入队。宿主不再需要先看 isStreaming。
  • 新增 isCommandInput(text):纯判据,命中 live-context 命令或已注册扩展命令;prompt 模板与 /skill: 明确不算(展开后仍是消息)。宿主自己的可编辑队列用它决定"不要把这行停在队列里"。
  • _isCommandName() 抽出一处判定,prompt() 的分发顺序(live-context → 扩展命令)与守卫共用,避免两套。
  • _throwIfExtensionCommand 改名 _throwIfCommand,把 /clm、/clm-compact 也纳入;报错文案改为 Command "/x" cannot be queued as a message. Use prompt() or submit() to run it, during or between runs.
  • LIVE_CONTEXT_COMMAND_NAMES 常量替代 _handleLiveContextCommand 里的字面量比较,slashCommandNameOf() 替代三处重复的 indexOf(" ") 切分。

2. CLI 删除重复的判断(apps/cli/)

isExtensionCommand 纯函数与 RuntimeContext.isExtensionCommand 删除,改用 session.isCommandInput();四处 streaming 提交从 prompt(text, { streamingBehavior }) 改为 submit(text, { duringRun })。CLI 行为不变,只是不再自己维护一份命令识别的副本。

3. 文档(packages/coding-agent/docs/sdk.md、docs/rpc.md、CHANGELOG.md)

sdk.md 写清"命令不是消息"、submit() 优先于 steer()、isCommandInput() 的用途,以及仍归宿主的边界:compaction 期间任何 prompt 都会被拒,宿主要在 compaction 结束后自己调用 submit()。

验证

  • 新增 test/suite/agent-session-submit.test.ts(7 条):命令在运行中立即执行且不进两个队列;默认 steer、duringRun: "followUp" 两种文本入队;空闲时直接开 turn;isCommandInput 对 /testcmd /clm /skill:x /usr/local/bin / 的判定;steer("/clm status") 被拒且不污染队列。
  • packages/coding-agent 定向:agent-session-submit + agent-session-queue 22 passed;apps/cli 全量 93 文件 762 passed。
  • 仓库级 ./test.sh:本机 git 是依赖 $HOME 的 shim,test.sh 清空 HOME 后所有 spawn git 的用例都会失败(与本次改动无关,env -i HOME=/tmp/x git --version 即可复现)。换用不依赖 HOME 的 shim 后全量通过。
  • tsgo --noEmit 与 biome check --error-on-warnings 干净。

边界

  • steer() / followUp() 保留:已经决定"这是消息"的宿主仍可直接用。
  • 桌面端宿主(apps/web)改用 submit() / isCommandInput() 是后续独立改动,走内场。

A command is not a message: prompt() dispatches it before it looks at the
run, which is why a host cannot queue or steer one. That rule lived only in
steer()'s guard, so every host re-derived it, and one that queued a command
sent the literal line to the model instead.

- submit(text, { duringRun }): the entry a host calls. Commands run on the
  spot during or between runs; text starts a turn or joins the running one.
- isCommandInput(text): the same question without side effects, for a host
  that keeps its own editable queue.
- The guard now covers the session's own /clm family, which prompt()
  dispatches itself and no extension registers. steer("/clm status") used to
  reach the model as text.
- One name split (slashCommandNameOf) and one predicate (_isCommandName)
  behind prompt(), submit(), isCommandInput() and the guard.

The CLI drops its own isExtensionCommand copy and submits through submit().
@liuedcson
liuedcson merged commit d687bb1 into main Nov 19, 2026
2 of 3 checks passed
@liuedcson
liuedcson deleted the feat/agent-session-submit branch November 19, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant