Repository navigation
Fix oversized logo flash during page load - #252
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the page loads, the Showcode logo can briefly fill the screen before the interface appears. The loader markup arrives before its styles, so the browser can render the SVG at the page width while it is still receiving the HTML.
This moves the loader styles and theme setup ahead of the markup, and gives the SVG explicit dimensions so it stays small even without CSS.
Verified with a slow HTML response in light, dark, and system themes. The logo stays at its intended size throughout loading. The production build also passes, and the loader disappears correctly when the interface is ready.