Repository navigation
fix(database): prevent incorrect identifier quoting inside function field expressions - #2331
Open
abu-tahir-0 wants to merge 1 commit into
Open
abu-tahir-0 wants to merge 1 commit into
abu-tahir-0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #2329.
When using SQL functions containing qualified column names in
select()(e.g.COUNT(item.id) AS countorAVG(order.total)),FieldStatement::compile()generates invalid SQL such asCOUNT(item.id)AScount``. This syntax error causes query execution to fail on MySQL and PostgreSQL.Root Cause
In
FieldStatement::compile(),$fieldis split on.before checking for function calls:When
$fieldisCOUNT(item.id), exploding on.produces['COUNT(item', 'id)']. Because only the first part contains(, the second partid)is incorrectly quoted byquoteIdentifier(), resulting inCOUNT(item.id)`.Solution
Check
if (! str_contains($field, '('))before exploding on.. When a field expression contains parentheses (indicating an aggregate function or expression), skip identifier quoting on the expression itself while preserving alias quoting (e.g.AS \count`orAS "count"`).Testing
FieldStatementTestcoveringCOUNT(item.id) AS countacross SQLite, MySQL, and PostgreSQL dialects.packages/database/testspass.Impact
Allows queries with aggregate functions or function calls referencing joined table columns to compile valid SQL without identifier quoting syntax errors.