Repository navigation
chore: bump deps - #15729
Merged
Merged
chore: bump deps#15729
Conversation
github-actions
Bot
added
mod:component
app:electron
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Walkthrough
Merge Risk: 🟠 High · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
The title identifies dependency updates, which are present, but it is too broad for a changeset that also modifies Cloud SQL Proxy deployment, Helm configuration, security contexts, Electron tooling, … | Use a specific title that names the primary change, such as "chore: update Electron and Vite dependencies and Cloud SQL Proxy deployment". |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. (9 skipped: 9 unsupported.)
-
Full details: Title check
-
Explanation
The title identifies dependency updates, which are present, but it is too broad for a changeset that also modifies Cloud SQL Proxy deployment, Helm configuration, security contexts, Electron tooling, and CI workflows.
Resolution
Use a specific title that names the primary change, such as "chore: update Electron and Vite dependencies and Cloud SQL Proxy deployment".
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Deploying blocksuite-docs with
|
| Latest commit: |
7351903
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c88e08d.blocksuite-docs.pages.dev |
| Branch Preview URL: | https://darksky-bump-deps-1022.blocksuite-docs.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
3bb9c72a-77e0-4586-ad6b-b5e3a824ca67
⛔ Files ignored due to path filters: 2
Cargo.lockis excluded by!**/*.lockyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing: 24
.github/actions/setup-node/action.yml.github/deployment/cloud-sql-proxy/Dockerfile.github/deployment/node/Dockerfile.github/helm/affine/Chart.yaml.github/helm/affine/charts/front/Chart.yaml.github/helm/affine/charts/front/templates/deployment.yaml.github/helm/affine/charts/front/values.yaml.github/helm/affine/charts/gcloud-sql-proxy/Chart.yaml.github/helm/affine/charts/gcloud-sql-proxy/templates/deployment.yaml.github/helm/affine/charts/gcloud-sql-proxy/values.yaml.github/helm/affine/charts/graphql/Chart.yaml.github/helm/affine/charts/graphql/templates/deployment.yaml.github/helm/affine/charts/graphql/values.yaml.github/helm/affine/values.yaml.github/workflows/build-images.yml.github/workflows/release-desktop.yml.nvmrcblocksuite/integration-test/package.jsonblocksuite/playground/package.jsonpackage.jsonpackages/backend/server/src/base/graphql/index.tspackages/frontend/apps/electron/package.jsonpackages/frontend/component/package.jsonpackages/frontend/core/package.json
💤 Files with no reviewable changes: 2
- .github/helm/affine/charts/front/Chart.yaml
- .github/helm/affine/charts/graphql/Chart.yaml
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #15729 +/- ##
==========================================
+ Coverage 54.62% 54.64% +0.02%
==========================================
Files 4024 4024
Lines 193186 193188 +2
Branches 31321 31334 +13
==========================================
+ Hits 105530 105570 +40
+ Misses 83695 83667 -28
+ Partials 3961 3951 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
61c90dda-26fd-4afa-92b5-9d0fe44d3bc2
📒 Files selected for processing: 11
.github/actions/deploy/deploy.mjs.github/helm/affine/Chart.yaml.github/helm/affine/charts/gcloud-sql-proxy/templates/NOTES.txt.github/helm/affine/charts/gcloud-sql-proxy/templates/deployment.yaml.github/helm/affine/charts/gcloud-sql-proxy/templates/service.yaml.github/helm/affine/charts/gcloud-sql-proxy/templates/serviceaccount.yaml.github/helm/affine/charts/gcloud-sql-proxy/templates/tests/test-connection.yaml.github/helm/affine/charts/gcloud-sql-proxy/values.yaml.github/helm/affine/values.yamlpackages/frontend/apps/electron/tsconfig.jsontools/utils/src/workspace.gen.ts
🚧 Files skipped from review as they are similar to previous changes: 2
- .github/helm/affine/Chart.yaml
- .github/helm/affine/charts/gcloud-sql-proxy/values.yaml
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
| isProduction || isBeta || isInternal | ||
| ? [ | ||
| `--set cloud-sql-proxy.enabled=true`, | ||
| `--set global.database.gcloud.enabled=true`, |
Contributor
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
sed -n '35,90p' .github/actions/deploy/deploy.mjs
rg -n 'global.database.host|DATABASE_URL|9801/startup|gcloud-sql-proxy|cloud-sql-proxy' .github/helm/affine .github/actions/deployRepository: toeverything/AFFiNE
Length of output: 10730
🏁 Script executed:
set -e
printf '%s\n' '--- deploy action and env bindings ---'
sed -n '1,115p' .github/actions/deploy/deploy.mjs
rg -n -C 5 -F -- 'DATABASE_URL' .github .env* 2>/dev/null || test "$?" -eq 1
printf '%s\n' '--- chart values and database contract ---'
sed -n '1,180p' .github/helm/affine/values.yaml
rg -n -C 5 -e 'database:' -e 'host:' -e 'port:' -e 'gcloud' .github/helm/affine/values.yaml .github/helm/affine/charts
printf '%s\n' '--- proxy helpers, service, deployment, and values ---'
sed -n '1,100p' .github/helm/affine/charts/gcloud-sql-proxy/_helpers.tpl
sed -n '1,100p' .github/helm/affine/charts/gcloud-sql-proxy/templates/service.yaml
sed -n '1,100p' .github/helm/affine/charts/gcloud-sql-proxy/templates/deployment.yaml
sed -n '1,100p' .github/helm/affine/charts/gcloud-sql-proxy/values.yaml
printf '%s\n' '--- startup and database consumers ---'
sed -n '1,110p' .github/helm/affine/charts/front/templates/deployment.yaml
sed -n '1,110p' .github/helm/affine/charts/graphql/templates/deployment.yaml
sed -n '1,75p' .github/helm/affine/charts/graphql/templates/migration.yaml
sed -n '1,105p' .github/helm/affine/templates/worker-deployment.yaml
printf '%s\n' '--- explicit host documentation and alternative bindings ---'
rg -n -C 4 -i -e 'DATABASE_URL' -e 'global\.database\.host' -e 'cloud.?sql.?proxy' -e 'connectionName' --glob '!**/node_modules/**' --glob '!**/dist/**' README.md docs .github 2>/dev/null || test "$?" -eq 1Repository: toeverything/AFFiNE
Length of output: 20191
🏁 Script executed:
set -u
printf '%s\n' '--- chart values and conditions ---'
nl -ba .github/helm/affine/values.yaml | sed -n '1,180p'
rg -n -C 6 -e 'database:' -e 'gcloud' -e 'enabled' .github/helm/affine/values.yaml .github/helm/affine/templates .github/helm/affine/charts
printf '%s\n' '--- proxy Service identity and ports ---'
nl -ba .github/helm/affine/charts/gcloud-sql-proxy/_helpers.tpl | sed -n '1,90p'
nl -ba .github/helm/affine/charts/gcloud-sql-proxy/templates/service.yaml | sed -n '1,80p'
nl -ba .github/helm/affine/charts/gcloud-sql-proxy/templates/deployment.yaml | sed -n '1,95p'
nl -ba .github/helm/affine/charts/gcloud-sql-proxy/values.yaml | sed -n '1,80p'
printf '%s\n' '--- startup consumers ---'
nl -ba .github/helm/affine/charts/front/templates/deployment.yaml | sed -n '25,95p'
nl -ba .github/helm/affine/charts/graphql/templates/deployment.yaml | sed -n '25,95p'
nl -ba .github/helm/affine/charts/graphql/templates/migration.yaml | sed -n '15,60p'
printf '%s\n' '--- workflow and action metadata ---'
nl -ba .github/workflows/release-cloud.yml | sed -n '35,90p'
nl -ba .github/actions/deploy/action.yml | sed -n '1,180p'
printf '%s\n' '--- DATABASE_URL format and host contract search ---'
rg -n -C 4 -i -e 'DATABASE_URL' -e 'global\.database\.host' -e 'cloud.?sql.?proxy' -e 'connectionName' --glob '!**/node_modules/**' --glob '!**/dist/**' --glob '!**/.git/**' . 2>/dev/null || test "$?" -eq 1Repository: toeverything/AFFiNE
Length of output: 42105
🏁 Script executed:
set -e
printf '%s\n' '--- helm release invocation ---'
nl -ba .github/actions/deploy/deploy.mjs | sed -n '105,190p'
printf '%s\n' '--- proxy fullname and Service ---'
nl -ba .github/helm/affine/charts/gcloud-sql-proxy/templates/_helpers.tpl | sed -n '8,26p'
nl -ba .github/helm/affine/charts/gcloud-sql-proxy/templates/service.yaml | sed -n '1,25p'
nl -ba .github/helm/affine/charts/gcloud-sql-proxy/values.yaml | sed -n '1,35p'
printf '%s\n' '--- front and GraphQL startup paths ---'
nl -ba .github/helm/affine/charts/front/templates/deployment.yaml | sed -n '28,48p'
nl -ba .github/helm/affine/charts/graphql/templates/deployment.yaml | sed -n '28,48p'
nl -ba .github/helm/affine/charts/graphql/templates/migration.yaml | sed -n '15,38p'
printf '%s\n' '--- DATABASE_URL contract ---'
nl -ba packages/backend/server/src/base/prisma/config.ts | sed -n '12,23p'
nl -ba .github/workflows/release-cloud.yml | sed -n '43,63p'Repository: toeverything/AFFiNE
Length of output: 9932
Pass the Cloud SQL Proxy Service name as global.database.host.
Stable, beta, and internal deploys pass the PostgreSQL DATABASE_URL to global.database.host. The front and GraphQL init containers then poll that value on port 9801, instead of polling the affine-cloud-sql-proxy Service. The pods can remain in their init containers until Helm's 10-minute timeout, causing the deployment to fail.
Suggested fix
- `--set-string global.database.host=${DATABASE_URL}`,
+ `--set-string global.database.host=affine-cloud-sql-proxy`,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Dependency Tree
This tree was auto-generated by Charcoal
Summary by CodeRabbit