Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thenav56
force-pushed
the
feat/api-tokens
branch
from
November 15, 2026 08:19
033ed86 to
76e2d82
Compare
thenav56
marked this pull request as ready for review
November 15, 2026 12:01
tnagorra
requested changes
Nov 16, 2026
Member
There was a problem hiding this comment.
Let's reuse this on the "Settings" page as well if we haven't done that already.
| return ( | ||
| <Link | ||
| className={_cs(styles.backLink, className)} | ||
| to="dailyJournal" |
Member
There was a problem hiding this comment.
"home" should be the default page not the "dailyJournal"
| .input-hint { | ||
| color: var(--color-text-muted); | ||
| font-size: var(--font-size-sm); | ||
| &.general.errored { |
Member
There was a problem hiding this comment.
We should be able to use nested style here.
| inputElementRef?: React.RefObject<HTMLInputElement | null>; | ||
| inputClassName?: string; | ||
| type?: 'text' | 'password'; | ||
| type?: 'text' | 'password' | 'date'; |
Member
There was a problem hiding this comment.
Do we need a date input?
We should already have a Date selection.
Need to check if can reuse that.
Member
There was a problem hiding this comment.
Do we also need to handle nested errors?
| } | ||
| } | ||
|
|
||
| .visually-hidden { |
Member
There was a problem hiding this comment.
Any reason for this "visually hidden"?
Comment on lines
+8
to
+26
| const dateFormatter = new Intl.DateTimeFormat( | ||
| [], | ||
| { | ||
| year: 'numeric', | ||
| month: 'short', | ||
| day: 'numeric', | ||
| }, | ||
| ); | ||
|
|
||
| const timestampFormatter = new Intl.DateTimeFormat( | ||
| [], | ||
| { | ||
| year: 'numeric', | ||
| month: 'short', | ||
| day: 'numeric', | ||
| hour: 'numeric', | ||
| minute: '2-digit', | ||
| }, | ||
| ); |
Member
There was a problem hiding this comment.
Don't we already have these in utils?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes