Skip to content

feat(api-token): add personal access tokens - #35

Open
thenav56 wants to merge 3 commits into
developfrom
feat/api-tokens
Open

thenav56 wants to merge 3 commits into
developfrom
feat/api-tokens

Conversation

@thenav56

Copy link
Copy Markdown
Member

Changes

  • Add support for PAT

thenav56 and others added 2 commits November 15, 2026 09:35
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thenav56 thenav56 changed the title fix(dropdown-menu): close menu when a link item is clicked feat(api-token): add personal access tokens Nov 15, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thenav56
thenav56 marked this pull request as ready for review November 15, 2026 12:01

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reuse this on the "Settings" page as well if we haven't done that already.

return (
<Link
className={_cs(styles.backLink, className)}
to="dailyJournal"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"home" should be the default page not the "dailyJournal"

.input-hint {
color: var(--color-text-muted);
font-size: var(--font-size-sm);
&.general.errored {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to use nested style here.

inputElementRef?: React.RefObject<HTMLInputElement | null>;
inputClassName?: string;
type?: 'text' | 'password';
type?: 'text' | 'password' | 'date';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a date input?
We should already have a Date selection.
Need to check if can reuse that.

Comment thread src/utils/errors.ts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to handle nested errors?

}
}

.visually-hidden {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this "visually hidden"?

Comment on lines +8 to +26
const dateFormatter = new Intl.DateTimeFormat(
[],
{
year: 'numeric',
month: 'short',
day: 'numeric',
},
);

const timestampFormatter = new Intl.DateTimeFormat(
[],
{
year: 'numeric',
month: 'short',
day: 'numeric',
hour: 'numeric',
minute: '2-digit',
},
);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we already have these in utils?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants