Repository navigation
🔧 build(lint): pin simplint 0.12.2 - #930
Merged
gaborbernat merged 16 commits intoNov 13, 2026
Merged
Conversation
gaborbernat
force-pushed
the
build/bump-simplint-0.12.0
branch
from
November 13, 2026 20:41
3294800 to
c4c5e1a
Compare
The parametrize list derived each seed's crash and stale-listing rates through two single-value for clauses; a constant now holds the cases.
Each of these tests only ran the code under test and passed as long as nothing raised. They now check the observable result: whether a writer can get in, the hold's generation, the mock's call count.
The participant cached its own holder path next to the token and root it is built from; deriving it keeps the participant within simplint's attribute limit.
BaseFileLock copied each LockSettings field onto its own attribute; it now keeps the settings object and reads the fields from it.
ReadWriteLock kept its level, mode and holder threads as separate attributes, and the connection's transaction flag and identity beside the connection holder. The hold now lives in _Hold, which owns the grant, nest and leave steps, and the connection state in _OwnedConnection.
The files, root, ledger and log only ever feed new participants, so a partial of Participant holds them. The compromise callback and the latest loss move together into _Losses.
While the spy is patched in, only the lease refresh calls lstat, so the filter never skips and branch coverage fell to 99% on every Linux job.
gaborbernat
force-pushed
the
build/bump-simplint-0.12.0
branch
from
November 13, 2026 22:31
65d124c to
7f413f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pins the simplint 0.12.2 hook for contributor and CI checks and resolves everything the newer rules report, so the lint job stays green on the new pin. The public API and lock behavior do not change. 🔧 simplint 0.12.2 no longer conflicts with Ruff's
unnecessary-regular-expression-compile, so the Ruff ignore kept for that conflict is gone.Lock internals
The new limit of 12 instance attributes per class caught four lock classes, and each now keeps related state together.
BaseFileLockholds its validated settings as a single value.ReadWriteLockkeeps its hold (level, mode, holding threads) in one object that also grants, nests and releases levels, and puts the SQLite connection's transaction and identity state next to the connection itself.SoftReadWriteLockbuilds participants from one factory that carries the shared log, ledger and files, and keeps the compromise callback together with the latest loss.FileLockContextkeeps its fields as they are because they are public API, so it carries a line ignore. ♻️The rest is automatic fixes (read-only module mappings,
functools.wrapson wrappers, monotonic timers), definitions moved below their first users, and assertions added to checks that previously passed as long as nothing raised.