Repository navigation
🧪 test: fix descriptor discovery and Windows coverage - #935
Open
hector2394 wants to merge 1 commit into
Open
hector2394 wants to merge 1 commit into
hector2394 wants to merge 1 commit into
Conversation
Static device nodes can hide live handles from the inode-reuse fixture. Windows checks need isolated heartbeat timing and capability-aligned coverage.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On NetBSD, static
/dev/fdnodes can make the capability probe accept an incomplete descriptor listing. The inode-reuse fixture then treats a live descriptor above that listing's range as closed, causing the successor-preservation test in #934 to remove the successor's marker.The probe now requires its descriptor node to disappear after close. Static nodes select the existing descriptor-number scan. A regression opens real handles above the directory's initial range and checks their counts as they close, without calling the private probe or mocking filesystem paths. Library locking behavior and the original failing test are unchanged.
The Windows junction-replacement test also uses the normal heartbeat defaults when staging the replacement tree. This keeps its setup independent of the fast heartbeat fixture while preserving the refusal and empty-target assertions. Symlink coverage now follows the existing capability guards, and the polling-policy test uses a controlled clock so it checks the requested sleep even on a loaded runner.
Fixes #934.
Validation:
test_failed_acquire_spares_a_successor_on_the_freed_inode_number#934 test also passes under controlled descriptor pressure without overriding the capability. Affected modules: 142 passed, 133 skipped.