Skip to content

🐛 fix(graalpy): fix the remaining weekly failures - #940

Merged
gaborbernat merged 4 commits into
mainfrom
fix/graal-remaining
Nov 16, 2026
Merged

gaborbernat merged 4 commits into
mainfrom
fix/graal-remaining

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

On GraalPy 25.4.4, releasing a soft lock whose marker a peer replaced raised AttributeError, and on runtimes whose os.link lacks dir_fd support, such as GraalPy 25.4.4, which does not implement linkat (source), read-write locks skipped the check that refuses a protocol directory another account owns under a sticky parent. Both are library bugs, and the weekly GraalPy job failed on them.

Soft-lock release now goes through a shared helper that rewinds the descriptor and writes when os.pwrite is missing (GraalPy 25.4.4 defines no pwrite in its posix builtins). Without dir_fd, soft read-write storage still pins each protocol directory on Windows, and on every platform it now checks the owner of each directory on every call.

🔐 The weekly GraalPy job also needed #939 and #942: the run after this merged still failed on fcntl.fcntl.

GraalPy 25.4.4 has no os.pwrite, so releasing a soft lock whose marker a
peer replaced raised AttributeError instead of rewriting the record.
write_at_start rewinds the descriptor and writes where pwrite is missing.
Without os.link dir_fd the protocol directories are used by name and
nothing is pinned, so the sticky-parent owner check made at prepare time
never ran again. Every call now refuses a directory another account owns,
as the descriptor path already does.
GraalPy has no gc.get_objects, so the live-future count the async give-up
test relies on cannot run there. Gate it on a capability, as the other
runtime differences are.
The owner recheck, the pwrite fallback and the release helper run only where
the POSIX capabilities hold, so mark each with its capability or win32 pragma
instead of leaving Windows coverage short.
@gaborbernat
gaborbernat merged commit c6549fd into main Nov 16, 2026
49 checks passed
@gaborbernat
gaborbernat deleted the fix/graal-remaining branch November 16, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant