Repository navigation
🐛 fix(graalpy): fix the remaining weekly failures - #940
Merged
Merged
Conversation
GraalPy 25.4.4 has no os.pwrite, so releasing a soft lock whose marker a peer replaced raised AttributeError instead of rewriting the record. write_at_start rewinds the descriptor and writes where pwrite is missing.
Without os.link dir_fd the protocol directories are used by name and nothing is pinned, so the sticky-parent owner check made at prepare time never ran again. Every call now refuses a directory another account owns, as the descriptor path already does.
GraalPy has no gc.get_objects, so the live-future count the async give-up test relies on cannot run there. Gate it on a capability, as the other runtime differences are.
The owner recheck, the pwrite fallback and the release helper run only where the POSIX capabilities hold, so mark each with its capability or win32 pragma instead of leaving Windows coverage short.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GraalPy 25.4.4, releasing a soft lock whose marker a peer replaced raised
AttributeError, and on runtimes whoseos.linklacksdir_fdsupport, such as GraalPy 25.4.4, which does not implementlinkat(source), read-write locks skipped the check that refuses a protocol directory another account owns under a sticky parent. Both are library bugs, and the weekly GraalPy job failed on them.Soft-lock release now goes through a shared helper that rewinds the descriptor and writes when
os.pwriteis missing (GraalPy 25.4.4 defines nopwritein itsposixbuiltins). Withoutdir_fd, soft read-write storage still pins each protocol directory on Windows, and on every platform it now checks the owner of each directory on every call.🔐 The weekly GraalPy job also needed #939 and #942: the run after this merged still failed on
fcntl.fcntl.