Repository navigation
🧪 test(coverage): exclude killed child loops from coverage - #943
Merged
Merged
Conversation
The breaker and crash helpers set an event, then loop until the test kills them. The kill can land before the loop line is traced, so coverage of that line depends on a race. Exclude the loop, where that race lives; everything up to the event is still measured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A macOS CI run missed coverage on the
while Trueloop of a child process the test kills, so the 100% coverage gate failed on a race. The test kills the child process, and the kill can land before the loop line is traced, so whether that line is counted depends on timing.🧪 The
while Trueloops that tests terminate are now excluded from coverage, with the reason, and the code before each kill is still measured. Library behavior does not change.