Skip to content

🧪 test(coverage): exclude killed child loops from coverage - #943

Merged
gaborbernat merged 1 commit into
mainfrom
fix/process-helper-coverage
Nov 16, 2026
Merged

gaborbernat merged 1 commit into
mainfrom
fix/process-helper-coverage

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

A macOS CI run missed coverage on the while True loop of a child process the test kills, so the 100% coverage gate failed on a race. The test kills the child process, and the kill can land before the loop line is traced, so whether that line is counted depends on timing.

🧪 The while True loops that tests terminate are now excluded from coverage, with the reason, and the code before each kill is still measured. Library behavior does not change.

The breaker and crash helpers set an event, then loop until the test kills
them. The kill can land before the loop line is traced, so coverage of that
line depends on a race. Exclude the loop, where that race lives; everything up
to the event is still measured.
@gaborbernat gaborbernat added the skip news Internal change; exempt from the news fragment check label Nov 16, 2026
@gaborbernat
gaborbernat merged commit 8890d79 into main Nov 16, 2026
50 checks passed
@gaborbernat
gaborbernat deleted the fix/process-helper-coverage branch November 16, 2026 18:08
@gaborbernat gaborbernat changed the title 🧪 test: exclude killed child loops from coverage 🧪 test(coverage): exclude killed child loops from coverage Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news Internal change; exempt from the news fragment check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant