Skip to content

🐛 fix(tests): check active Windows lock - #221

Merged
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/214-winlock-test
Nov 3, 2026
Merged

gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/214-winlock-test

Conversation

@gaborbernat

Copy link
Copy Markdown
Member

The lock-path test added in #214 fails on Windows because FileLock removes the file when it releases the lock. The post-release assertion fails even though locking works.

The test now checks that a second lock cannot acquire the same path while DiskContentStore holds it. This verifies the non-POSIX lock behavior without depending on the file after release.

@gaborbernat gaborbernat added bug Something isn't working skip news No user-facing changelog entry needed labels Nov 3, 2026
@gaborbernat
gaborbernat merged commit 5af3e30 into tox-dev:main Nov 3, 2026
21 of 22 checks passed
@gaborbernat
gaborbernat deleted the fix/214-winlock-test branch November 16, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working skip news No user-facing changelog entry needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant