Skip to content

Fix/zero code instruments dependencies - #4708

Open
hashaambajwa wants to merge 4 commits into
traceloop:mainfrom
hashaambajwa:fix/zero-code-instruments-dependencies
Open

hashaambajwa wants to merge 4 commits into
traceloop:mainfrom
hashaambajwa:fix/zero-code-instruments-dependencies

Conversation

@hashaambajwa

@hashaambajwa hashaambajwa commented Nov 13, 2026 •

Copy link
Copy Markdown
  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

Summary by CodeRabbit

  • Bug Fixes
    • Improved installation of the LangChain and Writer instrumentation extras by aligning their optional package requirements with the packages used at runtime. This helps ensure the instrumentation can be installed with compatible LangChain-based integrations and Writer SDK versions.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The LangChain and Writer instrumentation packages update the dependencies declared by their instruments extras. Each package adds a regression test that compares the extra’s metadata with the instrumentor’s runtime dependency.

Changes: LangChain Instrumentation

Layer / File(s) Summary
Extra dependency and metadata test
packages/opentelemetry-instrumentation-langchain/pyproject.toml, packages/opentelemetry-instrumentation-langchain/tests/test_instruments_extra.py
The instruments extra now declares langchain-core>0.1.0. The test checks that the extra’s requirement matches the runtime dependency.

Writer Instrumentation

Layer / File(s) Summary
Extra dependency and metadata test
packages/opentelemetry-instrumentation-writer/pyproject.toml, packages/opentelemetry-instrumentation-writer/tests/test_instruments_extra.py
The instruments extra now declares writer-sdk>=2.2.1,<3. The test checks that the extra’s requirement matches the runtime dependency.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: galkleinman, yanomaly

Merge Risk: Minimal · up to e6110

This change aligns the dependency extras for LangChain and Writer instrumentation with what the instrumentors check at runtime. It is a packaging metadata change with regression tests and shows no concrete merge risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "Fix/zero code instruments dependencies" points to the actual change. The PR changes the instruments extras of the LangChain and Writer instrumentation packages. The LangChain extra now re…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "Fix/zero code instruments dependencies" points to the actual change. The PR changes the instruments extras of the LangChain and Writer instrumentation packages. The LangChain extra now requires langchain-core instead of langchain. The Writer extra now requires writer-sdk&gt;=2.2.1,&lt;3 instead of writer. The new tests check both extras. The title names the area but not the specific dependency swap. It uses the branch-style "Fix/" prefix, which is a minor style issue.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 46f19b3e-5824-4c9a-880c-6886aab26c96
Commits

Reviewing files that changed from the base of the PR and between e3d651a and e61109b.

Files selected for processing: 4

  • packages/opentelemetry-instrumentation-langchain/pyproject.toml
  • packages/opentelemetry-instrumentation-langchain/tests/test_instruments_extra.py
  • packages/opentelemetry-instrumentation-writer/pyproject.toml
  • packages/opentelemetry-instrumentation-writer/tests/test_instruments_extra.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants