Repository navigation
Trailcode/shp copy - #271
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
New duplication paths touch Design geometry, Workbench links, selection, undo, and mode switching; the hotkey and sequential naming changes affect everyday editing workflows.
Overview
Adds in-place duplicate for Design and Workbench (Shift+D,
edit.duplicate): Design deep-copies selected solids (or the current group subtree); Workbench adds another link to the same body at the same pose. Copies stay under the original parent, get uniquified names, select the new nodes, enter Move, and record oneShape_add_deltaundo step without touching the copy/paste clipboard. Active move/rotate/scale/align previews are cancelled first; Sketch rejects the action.Remappable Delete now defaults to Ctrl+D so Shift+D can be Duplicate; Delete / Backspace still always delete. Settings defaults and user docs reflect
edit.duplicateand the new Delete chord.Copy naming fixes
unique_sequential_nameso a trailing.NNNis a sequence suffix (Box.001→ next freeBox/Box.002, notBox.001.001).Also documents and optionally lint-checks a C++ style rule: fold
for/whilebodies that are only a declaration plus anifinto an if-with-initializer, with matching refactors across the view/shape/sketch code and newShp_testcoverage for duplicate and naming.Reviewed by Cursor Bugbot for commit 8c4b5b7. Bugbot is set up for automated code reviews on this repo. Configure here.