Repository navigation
Use Node 26 for signature parity tooling - #66
Merged
Merged
Conversation
|
Coverage report for commit: 2bacce6 Summary - Lines: 90.55% | Methods: 65.22%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signature parity checks should exercise the SDK against the new Node 26 tooling runtime. Update CI and the development Docker image to exact Node 26.12.1, preserving the PHP support floor, PHP version/dependency matrix, and patched PHP 8.3.36 development image.
Validation: the Docker image builds; its Node runtime reports v26.12.1; all 30 existing offline PHPUnit tests pass with Node parity enabled (117 assertions), using a clean archive fixture and dummy credentials. Workflow YAML parsing and
git diff --checkpass. Council review: no issues found. The live API suite remains covered by normal CI.Validated commit:
2bacce6647aeed60a16d9d58fc9e31e6aa80119a.🤖 Claimed by kvz on
framework1/php-sdksince 2026-10-21 · resume:codex resume 01a15ee6-8ad4-7ec2-a0c6-c6d3ac36a367