Skip to content

Fix/logstash tests and docs - #310

Merged
Romakita merged 2 commits into
productionfrom
fix/logstash-tests-and-docs
Oct 3, 2026
Merged

Romakita merged 2 commits into
productionfrom
fix/logstash-tests-and-docs

Conversation

@Romakita

@Romakita Romakita commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Romakita and others added 2 commits October 3, 2026 18:12
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Romakita
Romakita merged commit f5ecb5b into production Oct 3, 2026
10 checks passed
@Romakita
Romakita deleted the fix/logstash-tests-and-docs branch October 3, 2026 16:20

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3597707dfd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +42 to +43
"test": "vitest run",
"test:ci": "vitest run --coverage.thresholds.autoUpdate=true"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Declare the test runner dependencies

When this workspace is installed or tested in isolation (for example through a focused workspace install), the new test script cannot find vitest, and its configuration also imports the undeclared @tsed/vitest/presets; the full monorepo currently masks both omissions through dependencies hoisted from other workspaces. Add vitest and @tsed/vitest to this package's devDependencies, and make the same correction in packages/logstash-udp/package.json.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant