Skip to content

Recompile plugin with steampipe-plugin-sdk v6.2.1 - #157

Merged
kaidaguerre merged 2 commits into
mainfrom
sdk-v6.2.1
Nov 13, 2026
Merged

kaidaguerre merged 2 commits into
mainfrom
sdk-v6.2.1

Conversation

@kaidaguerre

@kaidaguerre kaidaguerre commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Example query results

Results

Recompile only; no query run.

Built with go build -tags netgo; steampipe-plugin-sdk version in the binary:

$ go version -m steampipe-plugin-code.plugin | grep plugin-sdk
	dep	github.com/turbot/steampipe-plugin-sdk/v6	v6.2.1	h1:YRY5I8D59x/f2h0gvzigGU67myE2MgoH1GooDqMyuFc=

go build ./... && go vet ./... && go test -timeout 900s ./... exit 0; golangci-lint v2.15.0: 0 issues (3 errcheck before). Source changes: the /v5/ to /v6/ import lines, and defer resp.Body.Close() to defer func() { _ = resp.Body.Close() }() in three secret checkers.

What is updated

  • Recompiled with steampipe-plugin-sdk v5.x to v6.2.1.
  • Made the ignored resp.Body.Close() error explicit in three secret checkers (lint).

🤖 Generated with Claude Code

https://claude.ai/code/session_015W9uxM4eSoAonAH9qyyAkc

kaidaguerre and others added 2 commits November 13, 2026 13:20
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015W9uxM4eSoAonAH9qyyAkc
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015W9uxM4eSoAonAH9qyyAkc
@kaidaguerre

Copy link
Copy Markdown
Contributor Author

Reviewed at 4b5736f; e6b887f adds only the CHANGELOG entry reviewed

Review record

Class: not routine: besides the SDK version and import lines, the commit changes defer resp.Body.Close() to defer func() { _ = resp.Body.Close() }() in secrets/mailchimp_access_key.go, secrets/slack_token.go and secrets/stripe_api_key.go to clear 3 errcheck findings. /my-code-review --quick (small mechanical change).

Verdict: No issues found. All three agents (CLAUDE.md compliance, shallow bug scan, historical context) returned no findings on the change.

# Finding Outcome
1 CLAUDE.md agent: the Body.Close edit goes beyond the SDK bump. No change: it clears the errcheck findings the plugin's lint check reports (3 before, 0 after). Below the reporting threshold.
2 History agent noted older code outside this change: an unchecked res["ok"].(bool) assertion in slack_token.go:42 and HTTP clients without a timeout in the three secret checkers. No change: not touched by this change and not caused by it.

Checked in the review: each resp is assigned once with := and the defer follows the error return, so the closure closes the same body as before; no whole-file or line-ending rewrite (stat identical with whitespace ignored); no v5 import left.

CHANGELOG (script _Dependencies_ line only; past entries list only Go and SDK recompiles): no findings.

Checks at 4b5736f: go build, go vet, go test -timeout 900s ./... exit 0 (the secrets package tests pass); golangci-lint v2.15.0 (--max-same-issues=0 --max-issues-per-linter=0): 0 issues. (before the fix: 3 errcheck).

@kaidaguerre
kaidaguerre merged commit b591cf1 into main Nov 13, 2026
4 checks passed
@kaidaguerre
kaidaguerre deleted the sdk-v6.2.1 branch November 13, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants