Skip to content

Recompile plugin with steampipe-plugin-sdk v6.2.1 - #576

Merged
kaidaguerre merged 2 commits into
mainfrom
sdk-v6.2.1
Nov 13, 2026
Merged

kaidaguerre merged 2 commits into
mainfrom
sdk-v6.2.1

Conversation

@kaidaguerre

Copy link
Copy Markdown
Contributor

Recompiles the plugin with steampipe-plugin-sdk v6.2.1, which carries the query cache fixes for missing or duplicate rows from v6.2.0 and lowers plugin memory use.

What is updated

  • github.com/turbot/steampipe-plugin-sdk/v6 v6.0.0 → v6.2.1; github.com/turbot/go-kit v1.1.0 → v1.3.1.
  • github/utils.go: the REST and GraphQL client caches now use d.ConnectionCache instead of d.ConnectionManager.Cache, which SDK v6.2.1 marks Deprecated (staticcheck SA1019). Same cache, same keys and lifetime; a failed Set is now logged as a warning.

Integration test logs

Logs
Not run.

Example query results

Results

Recompile only; no query run.

Built with go build -tags netgo; steampipe-plugin-sdk version in the binary:

$ go version -m steampipe-plugin-github.plugin | grep plugin-sdk
	dep	github.com/turbot/steampipe-plugin-sdk/v6	v6.2.1	h1:YRY5I8D59x/f2h0gvzigGU67myE2MgoH1GooDqMyuFc=

go build ./... && go vet ./... && go test -timeout 900s ./... exit 0; golangci-lint v2.15.0: 0 issues.

🤖 Generated with Claude Code

https://claude.ai/code/session_015W9uxM4eSoAonAH9qyyAkc

kaidaguerre and others added 2 commits November 13, 2026 12:17
Lint fixes for the SDK's deprecation of QueryData.ConnectionManager (SA1019):
- github/utils.go: the REST and GraphQL client cache reads and writes in
  connect and connectV4 now use d.ConnectionCache with the query context;
  a failed cache write is logged as a warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015W9uxM4eSoAonAH9qyyAkc
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015W9uxM4eSoAonAH9qyyAkc
@kaidaguerre

Copy link
Copy Markdown
Contributor Author

Reviewed at 8811ef3; 7dc3398 adds only the CHANGELOG entry reviewed

Review record

Scope: origin/main..8811ef3f (SDK v6.0.0 → v6.2.1, github.com/turbot/go-kit v1.1.0 → v1.3.1, plus the SA1019 lint fix in github/utils.go: the REST (github_v3) and GraphQL (github_v4) client cache reads and writes in connect and connectV4 moved from the deprecated d.ConnectionManager.Cache to d.ConnectionCache with the query context; a failed Set is now logged as a warning) plus the v1.11.2 CHANGELOG entry. Not routine: task 7 lint fixes change .go lines beyond imports.

Review: /my-code-review --quick. Why quick: a small, mechanical like-for-like API swap at four call sites with no signature change. The quick pass found nothing real, so no step up to thorough. No CLAUDE.md exists in the clone, so the compliance pass had nothing to check.

Verdict: code: no issues found. CHANGELOG: two findings, both below the skill's reporting bar.

# Finding Outcome
1 The _Dependencies_ section leaves out the direct dependency move github.com/turbot/go-kit v1.1.0 → v1.3.1 (scored 45). The repo lists dependency moves as "Bumped" lines (v1.11.1), and has listed go-kit before. Applied: the lines under "Lines to add" are in the CHANGELOG entry, below the SDK line.
2 The entry does not describe SDK behaviour changes users can notice (scan errors instead of partial rows, admin call deadline) (scored 15). No change: every past SDK recompile entry in this repo is one clause plus a link to the SDK CHANGELOG, which carries the detail.

Lines to add:

- Bumped `github.com/turbot/go-kit` from v1.1.0 to v1.3.1.

Checked and found sound:

  • In SDK v6.2.1 the deprecated connection.Cache Get/Set pass straight through to the same ConnectionCache with context.Background(); keys keep their per-connection prefix and the one-hour lifetime, and github_v3 and github_v4 stay separate keys.
  • The new warnings repeat a failure the SDK already logs; harmless. The old result was never checked.
  • No ConnectionManager reference is left in any .go file; no comment went stale. Git history shows no earlier client-caching fix the change undoes.

Checks at 8811ef3: go build, go vet, go test -timeout 900s ./... exit 0 (no test files); golangci-lint v2.15.0 (--max-same-issues=0 --max-issues-per-linter=0): 0 issues.

@kaidaguerre
kaidaguerre merged commit 2cdcb71 into main Nov 13, 2026
4 checks passed
@kaidaguerre
kaidaguerre deleted the sdk-v6.2.1 branch November 13, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants