Repository navigation
layoutPicker: Use the monitor geometry for fullscreen monitors - #483
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
0 open findings
What changed in this PR
Updates the layout picker to use full monitor geometry on fullscreen monitors, avoiding hidden top-bar gaps.
Changes:
- Added fullscreen-aware geometry selection.
- Applied it to picker positioning and reveal hit testing.
| File | Description |
|---|---|
tiling-assistant@leleat-on-github/src/extension/layoutPicker.js |
Uses monitor or work-area geometry based on fullscreen state. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
A fullscreen window ignores struts, but GNOME Shell keeps the top bar's strut in place even though the bar itself is hidden. The work area thus still reserves space for it, which made the picker appear below where the top bar would have been, leaving an empty gap at the top. Use the monitor geometry for monitors with a fullscreen window instead, both when positioning the picker and for its reveal hit test. LP: #2170245
3v1n0
force-pushed
the
fullscreen-picker
branch
from
October 8, 2026 20:30
2da58ff to
fbd4c7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fullscreen window ignores struts, but GNOME Shell keeps the top bar's strut in place even though the bar itself is hidden. The work area thus still reserves space for it, which made the picker appear below where the top bar would have been, leaving an empty gap at the top.
Use the monitor geometry for monitors with a fullscreen window instead, both when positioning the picker and for its reveal hit test.
LP: #2170245