Skip to content

fix(webgui): backport time zone dropdown selection to 7.3 - #2856

Merged
tom mortensen (limetech) merged 1 commit into
7.3from
fix/timezone-selection-73
Nov 18, 2026
Merged

tom mortensen (limetech) merged 1 commit into
7.3from
fix/timezone-selection-73

Conversation

@elibosley

@elibosley Eli Bosley (elibosley) commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Related to DST-410.

Summary

Backport the searchable Time zone dropdown and its selection fixes from #2842 to WebGUI 7.3.

Why this exists

The 7.3 Date and Time page has a long time zone list. Search helps users find a zone, and the selection fixes let them reopen the list and apply changes reliably.

Resolution

Enable the upstream searchable widget on the Date and Time page. Clicking a closed field reopens the list even when the field still has focus. Choosing a different zone updates the native select and emits one bubbling change event so the page can apply the change.

Reviewer considerations

  • The original timeZone select owns the submitted value. Typing a search, dismissing the list, or choosing the current zone leaves the form unchanged.
  • The code, styles, docs, and tests use the same patch as feat(webgui): add reusable searchable dropdowns #2842 in 7.4.1-rc.0.1. The only omitted file is the original PR’s AI review marker.

Behavior changes

Users can filter by zone name or ID, select a result with the mouse or keyboard, and reopen the list after selecting a result or pressing Escape.

Implementation summary

The Date and Time page loads the shared jQuery UI widget and styles, then initializes the existing select after its options render.

Verification

  • node tests/searchable-select.cjs passed all five tests in Chromium, and BROWSER=webkit node tests/searchable-select.cjs passed the same five in WebKit.
  • PHP lint with short tags enabled, JavaScript syntax checks, and git diff --check passed.

Risk

The browser tests use the 7.3 branch assets and a representative settings form. The original #2842 PR plugin passed appliance QA on Unraid 7.3.2 at the exact upstream revision backported here. The #2856 plugin has no separate appliance QA result yet.

Backport the searchable Time zone picker and its selection fixes from #2842 (d513b6d). Include the upstream browser regressions and widget documentation.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8b9d7e21-2e47-47e7-b1d4-771f73e57015

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.11.18.1709
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2856/webgui-pr-2856.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/DateTime.page
emhttp/plugins/dynamix/README.md
emhttp/plugins/dynamix/javascript/jquery.searchable-select.js
emhttp/plugins/dynamix/styles/default-base.css
emhttp/plugins/dynamix/styles/jquery.searchable-select.css

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2856, or run:

plugin remove webgui-pr-2856

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@elibosley
Eli Bosley (elibosley) marked this pull request as ready for review November 18, 2026 22:05

@limetech tom mortensen (limetech) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@limetech
tom mortensen (limetech) merged commit ae3f5cc into 7.3 Nov 18, 2026
6 checks passed
@limetech
tom mortensen (limetech) deleted the fix/timezone-selection-73 branch November 18, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants