Repository navigation
Keep serving when network interface discovery is unavailable - #863
Closed
charan-rathore wants to merge 1 commit into
Closed
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
|
@charan-rathore is attempting to deploy a commit to the Internal Playground Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
No movement on this, so closing it off. Happy to revisit if there is interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #746.
Description
Added
Regression coverage for a throwing
os.networkInterfaces()and a normal external IPv4 address, plus a patch changeset and a README note.Changed
Defer interface discovery until
getNetworkAddressis called and return no network address when discovery fails. Importing the utility no longer queries the interfaces. Network discovery only supplies an optional banner URL, so its failure should not stop a local HTTP server.Removed
The import-time interface snapshot.
Caveats/Problems/Issues
Checked on Node 22.23.3 with pnpm 10.33.0 and the repository's Vitest 2.1.3:
pnpm test: TypeScript check and all 30 unit tests pass with coverage enabled.pnpm lintandpnpm compile: pass.Open #859 changes when network URLs are advertised for specific listeners. This fix only makes discovery optional and should compose; it does not change binding behavior or that PR's listener rules.
Checklist
pnpm test) pass.pnpm lintpasses.