Repository navigation
fix(pm): skip unavailable commands and reject unsupported options - #3286
Merged
fengmk2 merged 9 commits intoNov 3, 2026
Merged
Conversation
Warn and skip commands unavailable in the selected package manager version, and reject unsupported pnpm pack options before execution. Preserve Yarn Classic behavior and existing npm fallback semantics. Cover version boundaries and prereleases in unit tests and existing CLI snapshots. Leave dlx compatibility and Yarn optional-plugin detection out of scope.
jong-kyung
force-pushed
the
fix/pm-command-version-gates
branch
from
October 30, 2026 06:13
00354ad to
26dce19
Compare
Reject --shell-mode before pnpm 7.21.0 while preserving ordinary dlx. Cover older releases, the boundary prerelease, and the first supported stable version, with rejection snapshots for local and global CLIs. Leave npm-backed dlx behavior unchanged.
jong-kyung
marked this pull request as ready for review
October 30, 2026 07:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jong-kyung
changed the title
fengmk2
reviewed
Nov 1, 2026
Query the selected Yarn launcher before resolving commands so yarnPath and ignorePath determine the version used by command and option gates. Cover delegated unlink and patch saving, version overrides, and query failures with real Yarn CLI snapshots.
A user preload that prints to stdout made the Yarn version query unparseable, so every Yarn command failed. Remove NODE_OPTIONS from the query the same way the npm version query already does. Cover the case with a snapshot step that runs a printing preload.
This reverts commit 3a2bdb1.
This reverts commit eb4b2c7.
fengmk2
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent Vite+ from forwarding commands and named options to package manager versions that do not support them.
dlxandpackoptions before execution while keeping the base commands available.Version Reference
stagestageapprove-buildspatchandpatch-commitdlx --shell-modepack --outpack --jsonpack --pack-gzip-levelunlinkandpatch-commit --savenpm audit