Repository navigation
ci: pin Node 24 and socketsecurity in Socket scan - #353
Merged
Merged
Conversation
socketsecurity 2.11.2+ needs Node >= 22.13 for reachability analysis, and the nightly scan fails on Node 20. Pin Node 24 (recommended by Socket) and the CLI version so neither changes under the scan unannounced. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ping-huang1
marked this pull request as ready for review
October 26, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The nightly Socket Security Scan fails since
socketsecurity2.11.2: its reachability engine needs Node 22.13+, and this workflow pins Node 20 (Requires Node.js version 22.13.0 or higher (current: 20.x), exit code 3). Socket support confirmed the cause and recommends Node 24.node-version->"24"socketsecuritypinned to2.11.3(each CLI release pins its own reachability engine), instead of--upgrade, so the Node major version and the CLI version don't change without a deliberate bump (Node 24.x minor and patch releases still float). A comment in the workflow says to bump them together and check the Socket CLI changelog first.Mirrors webflow/webflow#125541.
QA Spec
After merge, run "Socket Security Scan" via
workflow_dispatchand confirm the job completes past "Run Socket Security Scan".CI-only change (GitHub Actions); no product code touched.
https://linear.app/webflow/issue/APPSEC-2300/investigate-and-fix-socket-scan-failure-in-the-various-repos