Repository navigation
Fix Backend tests failing on wip/1.3 - #1586
Merged
LukeTowers merged 1 commit intoOct 30, 2026
Merged
Conversation
Make the data providers static, as the PHPUnit version on wip/1.3 requires, and read refusal messages from the response's exception rather than the error page title, which Laravel 13 sets to the app name.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
LukeTowers
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Backend tests that came into
wip/1.3with the latest merge fromdevelopfail there (10 errors, 3 failures), so every PR againstwip/1.3is red. This changes only test files.wip/1.3requires data providers to bestatic. Eight providers inEditorSettingTest,BackendMarkupEscapingTestandReportContainerSecurityTestwere not.refusalMessage()inInspectableContainerSecurityTestandReportContainerSecurityTestread the message from the error page's<title>. On Laravel 13 that title is the app name ("Winter CMS"), so the helpers now read$response->exception->getMessage()instead. That does not depend on debug mode, so the twoConfig::set('app.debug', true)lines that existed only for the error page are removed.Testing
php artisan winter:testpasses locally for Backend (517 tests, up from 467 because the provider cases now run), System (383) and CMS (221).