[mjauvin]

  entity used for checkboxlist was being escaped and did not render as space anymore.

Summary by CodeRabbit

• Bug Fixes
  • Checkbox-list labels in read-only and editable lists no longer have already-encoded entities encoded again, keeping translated labels displayed correctly.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: f4cf1e0c-74ff-4e1f-a338-22caa51b013c

Commits

Reviewing files that changed from the base of the PR and between d411db6 and 93786e2.

Files selected for processing: 1

• modules/backend/widgets/form/partials/_field_checkboxlist.php

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The read-only and editable checkbox-list renderings now pass false to e() for translated labels. This disables double encoding in both renderings.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• wintercms/winter#1374: Added the checkbox-list renderers that this change updates.

Merge Risk: Minimal · up to 93786

No actionable merge-blocking risk remains in the reviewed change.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title accurately identifies the checkbox-list indentation fix described in the objectives. The code prevents double encoding of  , which restores the intended label indentation.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[damsfx]

Winter: 1.2.14
Php: 8.3+

Before:

After with @mjauvin PR:

The same thing happens in preview mode.