Repository navigation
WPB-22953: migrate connections to PostGreSQL - #5626
Merged
blackheaven merged 6 commits intoOct 30, 2026
Merged
Conversation
zebot
added
the
ok-to-test
blackheaven
force-pushed
the
gdifolco/WPB-22953-migration-postgres-connections
branch
from
October 21, 2026 22:41
13fc4ad to
6a9d599
Compare
| [resultlessStatement|INSERT INTO connection ("left", "right", status, last_update, conv) | ||
| VALUES ($1 :: uuid, $2 :: uuid, $3 :: int4, $4 :: timestamptz, $5 :: uuid?) | ||
| ON CONFLICT ("left", "right") DO UPDATE | ||
| SET status = ($3 :: int4), last_update = ($4 :: timestamptz), conv = ($5 :: uuid?) |
Contributor
There was a problem hiding this comment.
Does it make sense to upsert like this, what if there is a newer connection in postgres than in cassandra, wouldnt we want the newer data (i.e. the newer timestamp)?
Contributor
Author
There was a problem hiding this comment.
I have added a timestamp, not sure it fixes your concern, WDYT?
Contributor
There was a problem hiding this comment.
Yes, I think it does. I think it is only an edge case anyways but it never hurts to be careful.
blackheaven
force-pushed
the
gdifolco/WPB-22953-migration-postgres-connections
branch
from
October 23, 2026 16:19
f001ebc to
b5a1f1d
Compare
blackheaven
force-pushed
the
gdifolco/WPB-22953-migration-postgres-connections
branch
from
October 29, 2026 16:15
b5a1f1d to
3bba55b
Compare
VeryMilkyJoe
approved these changes
Oct 30, 2026
VeryMilkyJoe
left a comment
VeryMilkyJoe
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me :)
blackheaven
force-pushed
the
gdifolco/WPB-22953-migration-postgres-connections
branch
from
October 30, 2026 14:30
3bba55b to
ee55dcb
Compare
blackheaven
force-pushed
the
gdifolco/WPB-22953-migration-postgres-connections
branch
from
October 30, 2026 15:12
ee55dcb to
89b1b15
Compare
…s store in brig-integration testAllConnectionsPaging wrote remote rows straight to Cassandra while brig under PostgresqlStorage reads them from Postgres, so the test saw 5 instead of 8. Branch the seeding on postgresMigration.connections.
blackheaven
force-pushed
the
gdifolco/WPB-22953-migration-postgres-connections
branch
from
October 30, 2026 18:06
af97020 to
92f7950
Compare
LookupLocalConnectionsPage's marker lambda bound the status Int32 (second row field) instead of the right-user UUID, so every continuation request failed to decode the paging state, treated it as absent, and re-returned the full result set. Encode/decode now use the explicit ASCII UUID codec, mirroring the remote marker.
blackheaven
deleted the
gdifolco/WPB-22953-migration-postgres-connections
branch
October 30, 2026 23:45
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-22953
Checklist
changelog.d