Skip to content

WPB-29688: migrate brig nonce to PostGreSQL - #5675

Merged
blackheaven merged 6 commits into
developfrom
gdifolco/WPB-29688-migration-postgres-nonce
Oct 30, 2026
Merged

blackheaven merged 6 commits into
developfrom
gdifolco/WPB-29688-migration-postgres-nonce

Conversation

@blackheaven

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-29688

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven
blackheaven requested review from a team as code owners October 27, 2026 19:09
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 27, 2026
Comment on lines +1 to +5
-- WPB-29688: brig nonce (DPoP replay) store
--
-- No expires_at index / purge job, matching the password_reset precedent:
-- expiry is enforced on read and rows are consumed on use; unconsumed rows
-- are bounded by the 5-minute issuance TTL semantics and are tiny.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right place for this comment. We should move it to the postgres interpreter since this can change and we're not allowed to change migration files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to Wire.NonceStore.Postgres as requested.

@blackheaven
blackheaven force-pushed the gdifolco/WPB-29688-migration-postgres-nonce branch from 54d3244 to 4a80639 Compare October 29, 2026 15:57
@blackheaven
blackheaven force-pushed the gdifolco/WPB-29688-migration-postgres-nonce branch from 5f7f559 to 68af236 Compare October 29, 2026 22:44
randomName generates mixed-case names which brig rejects as invalid
handles ([a-z0-9_.-] only), failing putHandle deterministically.
@blackheaven
blackheaven merged commit 8a18657 into develop Oct 30, 2026
10 checks passed
@blackheaven
blackheaven deleted the gdifolco/WPB-29688-migration-postgres-nonce branch October 30, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants