Skip to content

fix(ios): complete stack commands when the iOS 26 transition ends - #8372

Draft
yedidyak wants to merge 2 commits into
masterfrom
fix/ios-26-stack-command-completion
Draft

yedidyak wants to merge 2 commits into
masterfrom
fix/ios-26-stack-command-completion

Conversation

@yedidyak

@yedidyak yedidyak commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

On iOS 26, push, pop, popTo, popToRoot and setStackRoot can leave their JS promise unresolved even though the native transition finished. performBlock:animated:completion: only completes from the CATransaction completion block, and on iOS 26 that block can be held back indefinitely by unrelated animations added to the same transaction (for example a toast or Liquid Glass tab bar animation starting while the pop runs). Anything awaiting the command then hangs.

  • also complete from the navigation controller's transitionCoordinator when the transition ends
  • guard the completion so it runs at most once, whichever path fires first
  • non-animated commands and iOS versions where the CATransaction completion arrives first behave as before; without a coordinator the message is a no-op

Verified in the Wix OneApp (RNN 8.9.0 with this change applied as a patch) on iOS 26.3 simulators, light and dark: flows that await pop()/popTo() before showing a toast or navigating (POS automatic discounts save, Pay Link, Stores product create) hung before the change and pass with it. iOS 18.6 runs of the same app showed no regressions.

On iOS 26 the CATransaction completion used by push, pop, popTo, popToRoot
and setStackRoot can be held back by unrelated animations in the same
transaction, so the command's JS promise never resolves although the
native transition finished. Also complete from the transition coordinator,
at most once.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant