Repository navigation
Conversation
On iOS 26 the CATransaction completion used by push, pop, popTo, popToRoot and setStackRoot can be held back by unrelated animations in the same transaction, so the command's JS promise never resolves although the native transition finished. Also complete from the transition coordinator, at most once.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS 26,
push,pop,popTo,popToRootandsetStackRootcan leave their JS promise unresolved even though the native transition finished.performBlock:animated:completion:only completes from theCATransactioncompletion block, and on iOS 26 that block can be held back indefinitely by unrelated animations added to the same transaction (for example a toast or Liquid Glass tab bar animation starting while the pop runs). Anything awaiting the command then hangs.transitionCoordinatorwhen the transition endsCATransactioncompletion arrives first behave as before; without a coordinator the message is a no-opVerified in the Wix OneApp (RNN 8.9.0 with this change applied as a patch) on iOS 26.3 simulators, light and dark: flows that await
pop()/popTo()before showing a toast or navigating (POS automatic discounts save, Pay Link, Stores product create) hung before the change and pass with it. iOS 18.6 runs of the same app showed no regressions.