Repository navigation
Conversation
Apps built with the iOS 27.1 SDK get UIKit's vertical bar on iPhone Duo: the tab bar becomes a floating platter on the trailing edge and `tabBar` turns into an empty placeholder column above it. - Don't set `tabBar.backgroundColor` while the tab bar is vertical. On iOS 26+ RNN painted the placeholder with `bottomTabs.backgroundColor`, which covered the system tabs: no tab was visible or tappable. Re-applied when `verticalBarEdge` changes (fold/unfold, scene resize). - `Constants.bottomTabsHeight` is 0 while the tab bar is vertical (it returned the full screen height, 678 on the outer display). - Bottom tabs with custom item views (`bottomTab.component`) opt out of the vertical bar: the custom row is a horizontal bar and was squeezed into the 69pt vertical column. - The side menu forwards the vertical bar preference to its children like it does for the status bar, so the opt-out above (and any child's preference) still applies under a side menu.
- `ios.sim.release.scene.duo` Detox configuration (iPhone Duo runtime, iOS 27.2). `DETOX_IOS_DEVICE_ID` pins one simulator by UDID for any iOS configuration. - `e2e/duo`: a simulator-only tool that folds and unfolds the device through SpringBoard's display tool service (private SPI, test tooling only), and a Detox helper around it. - `DETOX_DUO_POSE=closed|open` runs a whole suite on the outer or inner display. - `iPhoneDuo.test.js` folds and unfolds with bottom tabs, the custom tab row, a modal, an overlay and the side menu on screen. It returns early on other devices.
…utton.testID In the vertical bar UIKit hosts the back button outside the navigation bar, so backButton.testID was never applied. Fall back to the window's bar button that shows this stack's back item.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8374 (UIScene + RN 0.88). Review only the commits on top of it.
Why
iPhone Duo (
iPhone19,4, iOS 27.1+) is Apple's foldable iPhone. With the iOS 27.1 SDK, UIKit moves the tab bar and the navigation bar's items into a vertical bar on the trailing edge of both displays.UITabBarbecomes an empty placeholder column and the system draws the tabs in a floating platter. RNN worked against that in four places.Changes
tabBar.backgroundColorfrombottomTabs.backgroundColor. The placeholder is drawn above the system platter, so any app that sets a tab bar background color (the playground does) hides every tab. Detox:LAYOUTS_TAB … does not pass visibility percent threshold.verticalBarEdgechanges (fold, unfold, scene resize).Constants.bottomTabsHeightis the screen height (678 on the outer display), because the bar is 69×678.bottomTab.component) are squeezed into the 69pt column, and the native platter shows next to them.UIVerticalBarBehaviorDisabled, so the bar stays horizontal at the bottom.topBar.backButton.testIDis never applied. The back button is hosted outsidenavigationBarin the vertical bar.The side menu (
MMDrawerController,RNNSideMenuChildViewController) now forwardschildViewControllerForPreferredVerticalBarBehaviorthe same way it forwards the status bar. Without that, a child's preference (for example the custom-row opt-out above) is ignored under a side menu.Every change is inside
#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 270100+@available(iOS 27.1, *)or keyed onverticalBarEdge, so nothing changes on Xcode 26, on other iPhones and iPads, or on either life cycle.Testing on Duo: folding the simulator
Neither
simctlnor DeviceHub can fold the simulator.playground/e2e/duo/hinge.mis a simulator-only tool that asks SpringBoard's display tool service for a hinge swap, the same request Apple's internalsuiatool swapmakes. It is private SPI used only by e2e tooling, never by the library.ios.sim.release.scene.duoDetox configuration.DETOX_IOS_DEVICE_IDpins a simulator by UDID for any iOS configuration.DETOX_DUO_POSE=closed|openruns a whole suite on the outer (466×678) or inner (951×669) display.iPhoneDuo.test.jsfolds and unfolds live with bottom tabs, the custom row, a modal, an overlay and the side menu on screen. It returns early on other devices.Validation
iPhoneDuo.test.js: 5/5 pass. Before the fix, 3/5 fail (tabs not visible, so the modal and overlay flows can't be reached).Buttons › Resetting buttons should unmount button react viewfailed twice, then passed 4/4 with the same build (twice alone, twice in the full suite). The base code passed it 1/1. It's a flaky test; nothing in this PR runs on iOS 26.playgroundScene, Debug, Xcode 27.2, iPhone 18 Pro Max (iOS 27.2): 288 of 289 pass.RNNRootViewControllerTest testTopBarNoBorderOfffails on the base branch too.Not changed (works on Duo, or doesn't apply)
topBarHeightmatches the safe area.statusBarHeightis UIKit's own value (2 with the vertical status bar). It's documented, not changed.UIScreen.mainScreenstays the outer display (466×678) while the app is on the inner one (951×669). RNN's remainingmainScreenuses only set initial frames, and layout replaces them. A cold launch and pushes on the inner display render at full width. Moving them to the window scene's geometry is a possible cleanup, not done here.