Skip to content

Image manager RSA PSS support - #548

Merged
AlexLanzano merged 3 commits into
wolfSSL:mainfrom
bigbrett:img-mgr-pss
Oct 22, 2026
Merged

AlexLanzano merged 3 commits into
wolfSSL:mainfrom
bigbrett:img-mgr-pss

Conversation

@bigbrett

@bigbrett bigbrett commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Adds support for RSA PSS to the image manager wolfBoot verification methods.

Also one unrelated bugfix:

  • fixes CMAC argument checking and benchmark DMA buffer macro logic that was causing erroneous CMAC 0-size benchmarks on non-POSIX platforms

Copilot AI balanced review requested due to automatic review settings October 21, 2026 17:50

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bigbrett

Copy link
Copy Markdown
Contributor Author

@claude review

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #548

Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src
Not reviewed (no scan target covers them): docs/src/5-Features.md, docs/src/8-Integration.md, test-refactor/README.md, test/gen/wh_test_wolfboot_img_data.h, test/scripts/gen_wolfboot_test_data.sh
Coverage: 4 of 4 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

…improper CMAC 256 benchmarks on non-POSIX platforms
Comment thread src/wh_server_img_mgr.c
Comment thread src/wh_server_img_mgr.c
Comment thread src/wh_server_img_mgr.c
Comment thread src/wh_server_img_mgr.c
Comment thread test-refactor/client-server/wh_test_crypto_cmac.c
@AlexLanzano
AlexLanzano merged commit 8f0cf04 into wolfSSL:main Oct 22, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants