Skip to content

Test refactor: port cache keygen argument checks - #554

Open
padelsbach wants to merge 1 commit into
wolfSSL:mainfrom
padelsbach:test-refactor-cache-export-args
Open

padelsbach wants to merge 1 commit into
wolfSSL:mainfrom
padelsbach:test-refactor-cache-export-args

Conversation

@padelsbach

Copy link
Copy Markdown
Contributor

Add a handful of tests for arg validation for parity with legacy

Copilot AI balanced review requested due to automatic review settings October 30, 2026 02:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the test-only expansion of cache-key argument validation.

No open issues 🎉

What changed in this PR

Expands cache-key generation argument-validation tests in the refactored client-server suite to improve parity with legacy coverage. No production code changes are included.

Changes:

  • Adds RSA and ECC checks for ephemeral flags and null arguments.
  • Extends Curve25519, Ed25519, and ML-DSA checks beyond ephemeral-flag rejection, including ML-DSA DMA cases.
  • Registers the expanded tests and adds cleanup for any unexpectedly created cached keys.
File Description
test-refactor/​client-server/​wh_test_crypto_rsa.c Adds cache-key generation argument checks and registers the test.
test-refactor/​client-server/​wh_test_crypto_mldsa.c Expands argument checks for standard and DMA cache-key APIs.
test-refactor/​client-server/​wh_test_crypto_ed25519.c Extends ephemeral-flag checks with null-argument cases.
test-refactor/​client-server/​wh_test_crypto_ecc.c Adds cache-key generation argument checks and registers the test.
test-refactor/​client-server/​wh_test_crypto_curve25519.c Extends ephemeral-flag checks with null-argument cases.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants