Repository navigation
Test refactor: port cache keygen argument checks - #554
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the test-only expansion of cache-key argument validation.
No open issues 🎉
What changed in this PR
Expands cache-key generation argument-validation tests in the refactored client-server suite to improve parity with legacy coverage. No production code changes are included.
Changes:
- Adds RSA and ECC checks for ephemeral flags and null arguments.
- Extends Curve25519, Ed25519, and ML-DSA checks beyond ephemeral-flag rejection, including ML-DSA DMA cases.
- Registers the expanded tests and adds cleanup for any unexpectedly created cached keys.
| File | Description |
|---|---|
test-refactor/client-server/wh_test_crypto_rsa.c |
Adds cache-key generation argument checks and registers the test. |
test-refactor/client-server/wh_test_crypto_mldsa.c |
Expands argument checks for standard and DMA cache-key APIs. |
test-refactor/client-server/wh_test_crypto_ed25519.c |
Extends ephemeral-flag checks with null-argument cases. |
test-refactor/client-server/wh_test_crypto_ecc.c |
Adds cache-key generation argument checks and registers the test. |
test-refactor/client-server/wh_test_crypto_curve25519.c |
Extends ephemeral-flag checks with null-argument cases. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a handful of tests for arg validation for parity with legacy