Repository navigation
Test refactor: port ECDH and X25519 shared secret cache tests - #555
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the ECDH and X25519 shared-secret cache test additions.
No open issues 🎉
What changed in this PR
Ports ECDH and X25519 shared-secret cache tests into the refactored client-server test suite.
Changes:
- Checks cached secrets against export-mode results, including labels, assigned or explicit key IDs, and nonexportable behavior.
- Covers invalid arguments and blocking wrappers that import local keys.
- Integrates cache tests for P-256, P-384, P-521, and X25519.
| File | Description |
|---|---|
test-refactor/client-server/wh_test_crypto_ecc.c |
Adds per-curve ECDH cache tests and registers them in the async suite. |
test-refactor/client-server/wh_test_crypto_curve25519.c |
Adds X25519 cache tests and registers them in the Curve25519 suite. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.