Repository navigation
20261023-rng-nits - #11882
Merged
Merged
20261023-rng-nits#11882
Conversation
* fix stale Hash_DRBG_StirGenerate() comment (Hash_gen()/Hash512_gen() discard the zero-length block; nothing is banked for a continuous test); * log failed wc_FreeMutex()/wc_UnLockMutex() in RngAutoLockFree()/RngAutoLockExit() via WOLFSSL_MSG() instead of discarding the retval.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to diagnostics and a comment correction, with no unresolved review findings.
No open issues 🎉
What changed in this PR
This PR makes a small RNG cleanup, adopting diagnostic and comment fixes from #11850 without changing DRBG behavior.
Changes:
- Log mutex free and unlock failures through
WOLFSSL_MSG(). - Correct the stirring comment to explain that zero-length generation discards the generated block rather than retaining it for a continuous test.
| File | Description |
|---|---|
wolfcrypt/src/random.c |
Adds mutex failure diagnostics and corrects the Hash_DRBG_StirGenerate() comment. |
Review effort: Balanced
philljj
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfcrypt/src/random.c: cosmetic fixes:fix stale
Hash_DRBG_StirGenerate()comment (Hash_gen()/Hash512_gen()discard the zero-length block; nothing is banked for a continuous test);log failed
wc_FreeMutex()/wc_UnLockMutex()inRngAutoLockFree()/RngAutoLockExit()viaWOLFSSL_MSG()instead of discarding the retval.(adopts fixes from #11850)