Skip to content

2nd currency to CSBonusSeason - #279

Merged
WorkingRobot merged 2 commits into
xivdev:latestfrom
GurgumXIV:reward
Oct 17, 2026
Merged

WorkingRobot merged 2 commits into
xivdev:latestfrom
GurgumXIV:reward

Conversation

@GurgumXIV

Copy link
Copy Markdown
image

@github-actions

This comment has been minimized.

@Haselnussbomber

Copy link
Copy Markdown
Contributor

Looks more like the secondary "currency" item listed in the Mogpendium. I'd give those columns a different name. 🤔

@GurgumXIV

Copy link
Copy Markdown
Author

Looks more like the secondary "currency" item listed in the Mogpendium. I'd give those columns a different name. 🤔

I went back and forth on the name. Maybe Currency1/Currency2 or ItemReward1/ItemReward2? I was also hesitant to rename an old column.

@Haselnussbomber

Copy link
Copy Markdown
Contributor

Personally, I would go with Currency1/Currency2. I think that’s very easy to understand on first glance.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Validation succeeded

@GurgumXIV

Copy link
Copy Markdown
Author

Updated:
image

Thanks for the feedback, @Haselnussbomber !

@GurgumXIV GurgumXIV changed the title add ItemReward to CSBonusSeason 2nd currency to CSBonusSeason Sep 16, 2026
@WorkingRobot
WorkingRobot merged commit 0a4c1c3 into xivdev:latest Oct 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants