Repository navigation
Add credential-free CI with verified failure gates - #12
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core tests previously relied on local tool paths and could be mislabeled as Release. This change runs explicit Debug and Release suites, all Node tests, synthetic offline audits and static checks, Android Release JVM tests, and an unsigned main App Release compile on GitHub. A stable
CI requiredcheck accepts only successful results from every job.The workflow pins Actions/toolchains, validates discovery and reported results, retains failure evidence, and isolates build inputs from local configuration. Test fixes remove hardcoded Xcode paths, replace TMDB timing sleeps with synchronization, publish the loopback fixture port atomically, and preserve Python fixture diagnostics. README, Chinese README, contribution/build guidance and the changelog document coverage and limitations.
Validation: all seven checks in the final PR run passed: https://github.com/yaolin-dev/OKVideoMac/actions/runs/40349213188. Three macOS jobs initially received no runner and executed no steps; they passed after a capacity retry. The tested merge tree matches the implementation commit. Core Debug and Release each completed 1,233 discovered tests: 1,204 passed, 29 explicitly allowed skips, zero failures. Node: 55 passed; SourceAudit: 51 passed; crash configuration: 15 passed; symbol cases: 7 passed; CI validator tests: 28 passed; Android Release JVM: 45 passed. All 232 static inputs passed; 163 documentation file links were checked locally. The main App and two helpers compiled for arm64 Release with signing disabled.
The isolated intentional-failure run at https://github.com/yaolin-dev/OKVideoMac/actions/runs/40346059822 produced exactly one expected failure in each Core configuration and a failed aggregate check while all other jobs passed. Its faulty commit is not in this branch.
Existing AGP/Kotlin dependency-metadata lint diagnostics remain documented; full Android lint coverage is not claimed. Real playback/UI, live accounts and release signing/notarization remain separate checks. App runtime code, version 0.9.0 / Build 155, signed release assets, Desktop installation and branch-protection settings are unchanged.