Skip to content

ci(big-endian): install tzdata so pip check passes on the s390x image - #4570

Merged
d-v-b merged 2 commits into
zarr-developers:mainfrom
d-v-b:ci/big-endian-tzdata
Oct 26, 2026
Merged

d-v-b merged 2 commits into
zarr-developers:mainfrom
d-v-b:ci/big-endian-tzdata

Conversation

@d-v-b

@d-v-b d-v-b commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

adds tzdata to the docker image used for the big-endian tests, which zarr needs and debian sid doesn't provide.

closes #4562

For reviewers

[What would you most value a second look at? What are you already confident in? For a refactor, say whether behavior is meant to be unchanged.]

Author attestation

  • I am a human, these are my changes, and I have reviewed and understood every change and can explain why each is correct.

TODO

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Debian sid's python3-dateutil 3.0.0 declares a dependency on the
`tzdata` distribution, which no Debian package installs, so `pip check`
in the big-endian job fails before any test runs. Install tzdata from
PyPI in the image.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Oct 26, 2026
@d-v-b

d-v-b commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

self-merging when tests pass

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.73%. Comparing base (9b7b93b) to head (024f2e9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4570   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files          94       94           
  Lines       13706    13706           
=======================================
  Hits        12985    12985           
  Misses        721      721           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-v-b
d-v-b merged commit e28e7dc into zarr-developers:main Oct 26, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

big-endian CI failure

1 participant