Repository navigation
fixing windows wheel creation - #1014
Merged
Merged
Conversation
The cython sources where using int and long. However, on Windows, long is equivalent to int. Instead one should use long-long to ensure minimum int64. This is just annoying, but it now fully works. Also, one can't use stdlib int declarations in fused data-types because they cannot be coerced to proper cython data-types.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 414 414
Lines 54754 54754
=======================================
Hits 47442 47442
Misses 7312 7312 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cython sources where using int and long.
However, on Windows, long is equivalent to int.
Instead one should use long-long to ensure minimum int64.
This is just annoying, but it now fully works.
Also, one can't use stdlib int declarations in fused data-types because they cannot be coerced to proper cython data-types.
docs/changes/<num>.<type>.rst