Skip to content

fixing windows wheel creation - #1014

Merged
zerothi merged 2 commits into
mainfrom
windows-wheels
Aug 24, 2026
Merged

zerothi merged 2 commits into
mainfrom
windows-wheels

Conversation

@zerothi

@zerothi zerothi commented Aug 24, 2026 •

Copy link
Copy Markdown
Owner

The cython sources where using int and long.
However, on Windows, long is equivalent to int.
Instead one should use long-long to ensure minimum int64.

This is just annoying, but it now fully works.

Also, one can't use stdlib int declarations in fused data-types because they cannot be coerced to proper cython data-types.

  • Closes windows builds #1010
  • Added tests for new/changed functions?
  • Documentation for functionality in docs/
  • Changes documented in changes/<num>.<type>.rst

The cython sources where using int and long.
However, on Windows, long is equivalent to int.
Instead one should use long-long to ensure minimum
int64.

This is just annoying, but it now fully works.

Also, one can't use stdlib int declarations in fused
data-types because they cannot be coerced to proper
cython data-types.
@codecov

codecov Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.64%. Comparing base (3aee3e9) to head (f2925b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1014   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         414      414           
  Lines       54754    54754           
=======================================
  Hits        47442    47442           
  Misses       7312     7312           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zerothi
zerothi merged commit 33348d6 into main Aug 24, 2026
13 checks passed
@zerothi
zerothi deleted the windows-wheels branch August 24, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows builds

1 participant